Skip to content

Add configurable mmap prefetch pages support - #19662

Open
zeronerdzerogeekzerocool wants to merge 1 commit into
apache:masterfrom
zeronerdzerogeekzerocool:push-branches-zerocool-user
Open

zeronerdzerogeekzerocool wants to merge 1 commit into
apache:masterfrom
zeronerdzerogeekzerocool:push-branches-zerocool-user

Conversation

@zeronerdzerogeekzerocool

Copy link
Copy Markdown
Contributor

Ports the mmap prefetch limit from a hard-coded 100GB constant to an instance-level config (pinot.server.instance.mmap.prefetch.max.size), adapted to the current IndexLoadingConfig/SegmentDirectoryLoaderContext design so operators can tune or disable startup page-fault prefetching per deployment instead of being stuck with the old fixed value.

Instructions:

  1. The PR has to be tagged with at least one of the following labels (*):
    1. feature
    2. bugfix
    3. performance
    4. ui
    5. backward-incompat
    6. release-notes (**)
  2. Remove these instructions before publishing the PR.

(*) Other labels to consider:

  • testing
  • dependencies
  • docker
  • kubernetes
  • observability
  • security
  • code-style
  • extension-point
  • refactor
  • cleanup

(**) Use release-notes label for scenarios like:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed

Ports the mmap prefetch limit from a hard-coded 100GB constant to an
instance-level config (pinot.server.instance.mmap.prefetch.max.size),
adapted to the current IndexLoadingConfig/SegmentDirectoryLoaderContext
design so operators can tune or disable startup page-fault prefetching
per deployment instead of being stuck with the old fixed value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant