Skip to content

ci: pin site-link-validator to 0.2.5 and fix broken doc links - #3604

Merged
pjfanning merged 4 commits into
apache:mainfrom
pjfanning:ci-link-validator-0.2.5
Oct 9, 2026
Merged

pjfanning merged 4 commits into
apache:mainfrom
pjfanning:ci-link-validator-0.2.5

Conversation

@pjfanning

@pjfanning pjfanning commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Motivation

The scheduled Link Validator workflow has failed every week since #3457 bumped site-link-validator to 0.3.0 (example run):

ScalaDependenciesNotFound: Can't find a scala version suffix for net.runne::site-link-validator:0.3.0 (likely a non existing module or version)

0.3.0 and 0.4.0 are tagged on GitHub, but both release jobs failed to upload to Sonatype Central (401). The latest version on Maven Central is 0.2.5. With 0.2.5 in place, the validator reported 13 links with failure responses.

Modification

  • Pin the validator to 0.2.5 and drop the $GITHUB_STEP_SUMMARY argument, which 0.2.5 does not support.
  • Point Maven Central search links at Sonatype Central.
  • Link the logback manual's AsyncAppender section, because logback no longer serves its apidocs.
  • Link the pekko-management 2.0 docs for "app-version from Deployment". The page is not in current.
  • Update the Datadog stolen-CPU article URL, which has moved.
  • Add the sites that return 403 to bots (bugs.openjdk.org, cowtowncoder.medium.com, stackoverflow.com, waldo.scholars.harvard.edu) to ignore-prefixes. Also ignore the scala/runtime Scaladoc, which is not published; this replaces the individual AbstractFunctionN entries.
  • TEMP: the last commit adds a pull_request trigger so the validator runs on this PR. It must be dropped before merge.

Result

The Link Validator workflow runs again, and the links it reported are fixed or ignored.

Tests

  • Link Validator workflow run on this PR (via the temporary pull_request trigger)

References

Refs #3457

@pjfanning
pjfanning marked this pull request as draft October 9, 2026 09:05
Motivation:
The Link Validator workflow has failed at the cs launch step since
apache#3457 because site-link-validator 0.3.0 was never published to Maven
Central (its release job failed with a Sonatype 401).

Modification:
Use 0.2.5, the latest published version, and drop the
$GITHUB_STEP_SUMMARY argument that 0.2.5 does not support.

Result:
The link validator runs again.

Tests:
- Link Validator workflow run on the PR

References:
Refs apache#3457
@pjfanning
pjfanning force-pushed the ci-link-validator-0.2.5 branch from 53ba076 to 6adabef Compare October 9, 2026 09:27
@pjfanning pjfanning changed the title ci: pin site-link-validator to 0.2.5 ci: pin site-link-validator to 0.2.5 and fix broken doc links Oct 9, 2026

@raboof raboof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sorry about being trigger-happy with 0.3.0

Motivation:
The link validator reports 404s for moved pages and 403s from sites
that block automated clients.

Modification:
- Point Maven Central search links at Sonatype Central
- Link the logback AsyncAppender manual section (apidocs were removed)
- Point the pekko-management extref at the 2.0 docs, since the
  rolling-updates page is not in the current docs
- Update the moved Datadog stolen-CPU article URL
- Ignore sites that return 403 to bots (bugs.openjdk.org, medium,
  stackoverflow, waldo.scholars.harvard.edu) and the unpublished
  scala.runtime Scaladoc

Result:
The link validator reports no failure responses.

Tests:
- Link Validator workflow run on the PR

References:
None - link validator maintenance
@pjfanning
pjfanning force-pushed the ci-link-validator-0.2.5 branch from 6adabef to 796622e Compare October 9, 2026 09:33
Removed pull_request trigger from link-validator workflow.
@pjfanning
pjfanning marked this pull request as ready for review October 9, 2026 10:26
@pjfanning
pjfanning merged commit a0aaee3 into apache:main Oct 9, 2026
10 checks passed
@pjfanning
pjfanning deleted the ci-link-validator-0.2.5 branch October 9, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants