Skip to content

[index] lumina index build in flink support increment#7611

Merged
jerry-024 merged 1 commit intoapache:masterfrom
jerry-024:support_lumina_increment_build
Apr 10, 2026
Merged

[index] lumina index build in flink support increment#7611
jerry-024 merged 1 commit intoapache:masterfrom
jerry-024:support_lumina_increment_build

Conversation

@jerry-024
Copy link
Copy Markdown
Contributor

Purpose

Tests

@jerry-024 jerry-024 marked this pull request as draft April 8, 2026 06:53
@jerry-024 jerry-024 marked this pull request as ready for review April 8, 2026 10:14
Copy link
Copy Markdown
Contributor

@leaves12138 leaves12138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one correctness issue in the new incremental shard pruning logic. Separately, I still do not see any production caller that passes a non-default maxIndexedRowId, so after this patch CreateGlobalIndexProcedure still goes through the full-build path.
-- written by codex

@jerry-024 jerry-024 requested a review from leaves12138 April 9, 2026 09:09
Copy link
Copy Markdown
Contributor

@leaves12138 leaves12138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jerry-024 jerry-024 merged commit 1e1c9f4 into apache:master Apr 10, 2026
12 checks passed
@jerry-024 jerry-024 deleted the support_lumina_increment_build branch April 10, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants