Repository navigation
Conversation
Contributor
Author
Looks like unrelatd failure |
Member
@ZENOTME The |
ZENOTME
force-pushed
the
feat/c-api-table-write-close
branch
from
November 4, 2026 12:37
103421c to
fabf5bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Expose existing
TableWrite::close()through the C API for explicit cleanup. Closes #1302.Brief change log
Add
paimon_table_write_close()using existing C binding conventions. Prepared messages remain caller-owned; free the handle separately.Tests
Reuse
test_write_commit_read_roundtrip: close the writer before committing its prepared messages, then verify the existing readback. No new fixture. Formatting checks pass.API and Format
One additive C function; no storage format changes.
Documentation
Rustdoc describes ownership and handle lifetime.