Repository navigation
Conversation
|
Hi @JingsongLi, @QuakeWang Could you please review this PR when you have time? It fixes quoted alias handling in MERGE statements and adds regression tests. Thanks! |
|
Requirement fit against current main: superseded by #1315. Implementation: CLEAN at 63e1c70; the 26 MERGE tests pass in an isolated worktree. The native MERGE implementation now merged at 062f1bc removes the SQL reconstruction and textual alias comparisons changed here. DataFusion resolves quoted aliases before Paimon binds columns by schema position; partition pruning also uses resolved target/source columns. I verified current main with independent public-SQL round trips covering all six alias forms from this PR, ordinary and data-evolution tables, table and subquery sources, and matched UPDATE / unmatched INSERT followed by DELETE (24 combinations). All pass. The four case-sensitive partition/normalization scenarios from the follow-up fix also pass, alongside the 16 existing native MERGE integration tests. Closing this implementation as superseded: merging it would restore changes to a replaced execution path without adding observable behavior. The regression cases are useful and can be retained separately in the native MERGE test suite if desired. Please reopen with a failing example on current main if any quoted-alias case remains unsupported. |
|
@JingsongLi Thanks for your help and review! Closing this PR makes sense since #1315 has resolved the issue. |
Purpose
Linked issue: closes #1269
Fix MERGE statements failing with aliases containing spaces, reserved words, embedded quotes, or case-sensitive names.
Brief change log
Tests
API and Format
No.
Documentation
No.