HDDS-16078. [STS] Branch merge checklist - #523
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
||
| ## 2. Documentation | ||
|
|
||
| [User documentation](https://ozone.apache.org/docs/next/administrator-guide/operations/s3/sts) for Ozone S3 Security Token Service (STS) has been added. |
There was a problem hiding this comment.
https://ozone.apache.org/docs/next/administrator-guide/operations/s3/sts is not accessible.
There was a problem hiding this comment.
right, it should be accessible once #510 is merged
| </property> | ||
| ``` | ||
|
|
||
| A new RocksDB table stores revoked STS token entries. No OM versioning-framework feature flag is used. |
There was a problem hiding this comment.
We can add the table name here.
|
|
||
| ## 7. Coverage / Code quality | ||
|
|
||
| [New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-13323-sts) for STS (HDDS-13323-sts) is **89.1%** and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-13323-sts) is **75.4%**. |
There was a problem hiding this comment.
89.1% is a very good data.
There was a problem hiding this comment.
master was merged into my branch yesterday and code coverage plummeted to 81.58% - not sure why. Previously the last analysis was done around 19 days ago, and I looked at the commits I added since then and they were mostly smoke tests.
There was a problem hiding this comment.
The new code coverage includes all new commits, not just the commits of this feature branch. So it will drop when merged the master, the same observation from previous feature branch merge time.
|
|
||
| ## 5. Docker-compose / Acceptance tests | ||
|
|
||
| New robot tests `ozone-secure-sts.robot` and `ozone-secure-sts-multitenant.robot` are being added. Furthermore, a shell script to test Polaris with Ozone STS (`polaris-smoketest.sh`) is being added. |
There was a problem hiding this comment.
We can add the link for ozone-secure-sts.robot, ozone-secure-sts-multitenant.robot and polaris-smoketest.sh later once they are merged.
There was a problem hiding this comment.
updated to add links
Use "milliseconds" instead of "millis" in the s3RevokedStsTokenTable row. Co-authored-by: Cursor <cursoragent@cursor.com>
3 participants
Please describe your PR in detail:
What is the link to the Apache Jira?
https://issues.apache.org/jira/browse/HDDS-16078
How was this patch tested?
Tested in docker compose (viewing web page)