Implements Jakarta Persistence 3.2 by cristof · Pull Request #144 · apache/openjpa

cristof · 2026-05-16T18:41:02Z

Hi! This work is an effort to implement JPA 3.2. I've started it a long time ago. Richard Zowalla picked it up and, with AI help (Claude), implemented the missing features, including some JPA <3.0 that weren't implemented.
I've tested it against default database, h2, mariadb(lts) e postgresql (18).
Please, check it against your favorite DB so we may fix some edge cases. It would be great if you can run TCK to be sure of the implementations.

* Reverting unnecessary changes * Fixing broken map synchronization

* Changing signature of BrokerFactory API on schema dealing validate method * Adding test to check if validate operation throws exception when it fails * Changing GH CI workflow to allow usage of both self-hosted and GH hosted runners * Tested on derby, h2-2, postgresql:latest, mysql:lts, mariadb:lts

* Implementing emf creation passing PersistenceConfiguration

…openjpa one

* Removing unused import in BrokerImpl * Implemented new PersistenceUnitUtil load methods

…model

* Moved PUU loading tests to test unit already present * Updated test unit to junit 4.x format

* Original impl was wrongfully dependent of persistence.xml file * Fixed this issue, but still lacking actual conversion of PersistenceConfiguration properties to openjpa corresponding properties

…iguration) method

* added update OracleDictionary to use unqualified table name from main * added temporary file information disclosure vul-fix from main

…tence.xml * Added tests of specifications supported * Added support for scope and qualifiers in PersistenceUnitInfo and persistence.xml

Added function and corresponding tests, but MySQL still fails in tests. Passed on h2-2, pg, mariadb.

* fixed behavior on MySQL * tested on derbdb, h2-2, mysql lts, mariadb lts, postgresql

… is a number

…ing db (derbydb)

… support them)

rzo1 · 2026-07-17T05:22:40Z

How do you run the tests exactly? They require quite a lot of properties 🙃

solomax · 2026-07-17T05:24:41Z

I'm using: reset && ./run-tck32.sh :)
It starts Postgres:16 and runs everything

As I understand for some reason jpa.provider.implementation.specific.properties is not working
I'll try to debug :)

rzo1 · 2026-07-17T06:15:28Z

@solomax I looked into the Client2#createEntityManagerFactoryNoBeanValidatorTest issue and could reproduce both states on PostgreSQL 16. The test actually passes without the bval change: it verifies JPA spec 3.6.1 — ValidationMode.CALLBACK with no Bean Validation provider on the classpath must end in a PersistenceException, and OpenJPA already throws it (ValidationUnavailableException → wrapped in PersistenceProviderImpl). The ERROR ... A default ValidatorFactory could not be created stack trace in the log is expected output on the passing path.

That's also why the TCK runs this single test in the separate persistence-tests-2 execution: persistence-tests-1 gets hibernate-validator via ${validator.classes}, while persistence-tests-2 deliberately has no validator. Adding org.apache.bval.bundle to our profile puts a validator on both classpaths, so the EMF now gets created, em.persist() runs, and it fails on the unenhanced Order/Member classes instead — could you revert 4588093?

Re jpa.provider.implementation.specific.properties "not working": for this one test that's by TCK design — Client2 passes the raw myProps to createEntityManagerFactory and never calls PMClientBase.getPersistenceUnitProperties(), which is the only place that string gets parsed into openjpa.* properties. For all other tests it works fine.

Verified A/B/A on postgres:16 with a fresh branch-tip build, running only the persistence-tests-2 execution: without bval → Tests run: 1, Failures: 0, Errors: 0; with bval → the ArgumentException: This configuration disallows runtime optimization failure you saw; reverted → green again.

solomax · 2026-07-17T06:28:03Z

You are right @rzo1, for whatever reason the test was red for me

Reverted and GREEN :)

I'll try to add parametrization and perform more tests

rzo1 · 2026-07-17T06:31:32Z

I am currently looking into my suggestion regarding Romains comment.

…thout a version, so optimistic lock failures still surface Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

solomax · 2026-07-17T10:31:05Z

Just commited updated run-tck32.sh
It is now able to run TCK against MySql with DB_TYPE=mysql ./run-tck32.sh (version can also be specified

My results are:
[ERROR] Tests run: 2134, Failures: 0, Errors: 145, Skipped: 4

I'll try to take a look at all this later :)

…n running on Oracle

cristof · 2026-07-17T13:24:49Z

Kubernetes flukes aside, Oracle build is now green, skipping only tests where there is no database support (TIME data type, CURRENT_TIME and EXTRACT(QUARTER from)). Ran the tests on oracle-xe-18 and oracle-xe-21.
Provided the TCK tests are ok, I think we could update the docs and (pre?) release?

solomax · 2026-07-18T12:12:19Z

It seems some errors in MySQL TCK tests are caused by:

Caused by: org.apache.openjpa.lib.jdbc.ReportingSQLException: Data truncation: Data too long for column 'CHARDATA' at row 1 {prepstmnt 2112012700 INSERT INTO DATATYPES (id, BOOLEANDATA, BYTEARRAYDATA, BYTEDATA, CHARARRAYDATA, CHARDATA, DBLDATA, ENUMSDATA, FLOATDATA, INTDATA, INTDATA2, LONGDATA, SHORTDATA) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)} [code=1406, state=22001]
	at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator.wrap(LoggingConnectionDecorator.java:219)
	at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator.wrap(LoggingConnectionDecorator.java:195)
	at org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator$LoggingConnection$LoggingPreparedStatement.executeUpdate(LoggingConnectionDecorator.java:1188)
	at org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedStatement.java:308)
	at org.apache.openjpa.jdbc.kernel.JDBCStoreManager$CancelPreparedStatement.executeUpdate(JDBCStoreManager.java:1867)

While trying to persist entity with:

	@Column(name = "CHARDATA")
	protected char characterData;

Table is create with:

CREATE TABLE DATATYPES (ID INTEGER NOT NULL, BOOLEANDATA SMALLINT NULL, CHARDATA CHAR NULL, SHORTDATA SMALLINT NULL, INTDATA INTEGER NULL, INTDATA2 INTEGER NULL, LONGDATA NUMERIC NULL, DBLDATA DOUBLE PRECISION NULL, FLOATDATA REAL NULL, ENUMODATA INTEGER NULL, ENUMSDATA VARCHAR(25), BYTEDATA SMALLINT NULL, TRANS SMALLINT NULL, BYTEARRAYDATA BLOB, CHARARRAYDATA VARCHAR(448), CONSTRAINT PK_DATATYPES PRIMARY KEY (ID) ) ENGINE=innoDB DEFAULT CHARSET=latin1 !

java oblect is created with:

			char[] cArray = { 'a' };
			byte[] bArray = { (byte) 100 };
			d1 = new DataTypes(1, false, (byte) 100, 'a', (short) 100, 300, 600L, 50D, 1.0F, cArray, bArray);

Something weird :(((

rzo1 · 2026-07-21T06:15:07Z

Kubernetes flukes aside, Oracle build is now green, skipping only tests where there is no database support (TIME data type, CURRENT_TIME and EXTRACT(QUARTER from)). Ran the tests on oracle-xe-18 and oracle-xe-21. Provided the TCK tests are ok, I think we could update the docs and (pre?) release?

OpenJPA historically never passed the full TCK - so we can either try to get it green (again) for certain rdbms or we make a (pre?) release with updated docs and do the TCK work in another follow up PR? wdyt?

solomax

+1 to merge this PR as is (with squash and merge, I guess)
And to continue polishing in next PRs :))

@rmannibucau I would appreciate your approve as well

BTW I will be on vacation for a week or so, so might be silent :)

cristof · 2026-07-21T18:48:17Z

+1 to merge and create a release candidate, but I guess it would be better to keep the commit history instead of squashing it to allow future fixes.

cristof · 2026-07-30T12:31:23Z

@solomax, did openjpa pass the TCK in others DBs?

rmannibucau

The 90 comments tagged (high)/(medium)/(low) below were prepared with the help of Claude; the untagged ones are mine. Points already discussed in existing threads were deliberately skipped.

rmannibucau · 2026-07-30T12:41:51Z

                        <goals>
                            <goal>unpack</goal>
                        </goals>
+                        <?m2e ignore?>


really needed? it is out of maven schema anyway, no comment flavor?

rmannibucau · 2026-07-30T13:21:47Z

+    exit 1
+fi
+
+stopAll() {


(medium) stopAll runs unconditionally at startup and issues docker:stop with name patterns like postgres*/mysql* for all four DB profiles, even when DB_HOST points at an external database - that can kill unrelated containers on a developer machine and adds four mvn invocations per run. Suggest guarding with START_DOCKER and limiting to the selected DB_TYPE.

@rmannibucau (this one is mine :))))

this call was added to stop all stalled dockers from previous runs (better to use trap and perform clean-up, but this dirty solution much easier :)))

I would leave it as-is but also can change if you insist :)

rmannibucau · 2026-07-30T13:21:48Z

+fi
+
+echo ""
+echo "=== Preparing ${DB_TYPE} database ==="


(low) "=== Preparing ${DB_TYPE} database ===" is an empty leftover (Step 5 is missing between Step 4 and Step 6), yet the README claims this step drops stale tables and creates stored procedures. Either implement it or drop the heading and fix the README.

I'll perform clean-up (missing DB tables are being created by maven and dropped by docker:remove ...)

rmannibucau · 2026-07-30T13:21:50Z

@@ -1163,7 +1164,7 @@ data structure.
                            lifecycle callbacks
                        </seealso>
                    </indexterm>
-<ulink url="http://download.oracle.com/javaee/6/api/javax/persistence/PreUpdate.html">
+<ulink url="https://jakarta.ee/specifications/persistence/3.2/apidocs/jakarta.persistence/jakarta/persistence/postupdate">


(low) Copy/paste nit: the PreUpdate entry links to .../jakarta/persistence/postupdate - should be preupdate (line 1191 is the correct PostUpdate one).

rmannibucau · 2026-07-30T13:21:51Z

+    <id>openjpa</id>
+    <properties>
+        <glassfish-artifact-id>glassfish</glassfish-artifact-id>
+        <openjpa.version>4.2.0-SNAPSHOT</openjpa.version>


(low) The injected profile hardcodes <openjpa.version>4.2.0-SNAPSHOT</openjpa.version>; the script always overrides it via -Dopenjpa.version, but the default silently goes stale after release - maybe add a comment that it must be kept in sync (same for the defaults baked into the README examples).

rmannibucau

overall good even if a few things surprised me, made claude running on it and he superseeded my review so just let him push his comment, several are worth checking, some are just "nice" but can be ignored IMHO

* In-memory JPA environment would incur in infinite loop when using REPLACE if the replacement string contains the replaced one * Fixes casts in TypecastAsNumber when running in-memory JPA env * Adds support for java.util.Date and fixes java.sql.Date treatment in TypecastAsString when running in-memory JPA env

LEFT and RIGHT now mimic behavior of PostgreSQL equivalent functions

… gitignore entries

…dProcedureQuery

…Class via PCEnhancer.isPCSubclassName

…s in in-memory JPAs

cristof added 30 commits July 11, 2025 17:01

[OPENJPA-2940][WIP] Using self-hosted runner to test builds

4035997

[OPENJPA-2940][WIP] Intermmediate commit

cc17e19

* Reverting unnecessary changes * Fixing broken map synchronization

[OPENJPA-2940][WIP] Adjusting GH action workflow

1f84355

[OPENJPA-2940][WIP] Intermmediate commit

898a228

* Implementing emf creation passing PersistenceConfiguration

[OPENJPA-2940][WIP] Changing test to use jakarta property instead of …

6ffc634

…openjpa one

[OPENJPA-2940][WIP] Implemented call and run in transaction EMF methods

85fb761

[OPENJPA-2940][WIP] Intermmediate commit

9ae04d7

* Removing unused import in BrokerImpl * Implemented new PersistenceUnitUtil load methods

[OPENJPA-2940][WIP] Fixing unused imports, adding javadoc

f31d52e

[OPENJPA-2940][WIP] Implemented JPA 3.2 entity(String) method in Meta…

b96b230

…model

[OPENJPA-2940] Reverting changes to default GH actions workflow

d9f4e70

[OPENJPA-2940][WIP] Implementing PUU.getVersion and isInstance

284a75c

* Moved PUU loading tests to test unit already present * Updated test unit to junit 4.x format

[OPENJPA-2940][WIP] Merge branch 'master' into OPENJPA-2940

ed8fe32

[OPENJPA-2940][WIP] Implementing PUU.getClass(T entity).

8e3731e

[OPENJPA-2940][WIP] Fixing partial impl

6189cbd

* Original impl was wrongfully dependent of persistence.xml file * Fixed this issue, but still lacking actual conversion of PersistenceConfiguration properties to openjpa corresponding properties

[OPENJPA-2940][WIP] Fixing createEntityManagerFactory(PersistenceConf…

569e3f0

…iguration) method

[OPENJPA-2940][wip] Merge branch 'master' into OPENJPA-2940

f9833f9

* added update OracleDictionary to use unqualified table name from main * added temporary file information disclosure vul-fix from main

[OPENJPA-2940][WIP] Adding support for scope and qualifiers in persis…

44c5733

…tence.xml * Added tests of specifications supported * Added support for scope and qualifiers in PersistenceUnitInfo and persistence.xml

[OPENJPA-2940][WIP] Implementing em.find with FindOption

ffb548b

[WIP][OPENJPA-2940] Implementing JPQL CAST TO STRING

4ad9ceb

[WIP][OPENJPA-2940] Implementing CAST TO NUMBER JPQL function

2d677d8

Added function and corresponding tests, but MySQL still fails in tests. Passed on h2-2, pg, mariadb.

[WIP][OPENJPA-2940] Completed cast to number JPQL function

6e3aa4e

* fixed behavior on MySQL * tested on derbdb, h2-2, mysql lts, mariadb lts, postgresql

[WIP][OPENJPA-2940] Implementing Criteria typecast support

003f5e5

[WIP][OPENJPA-2940] Fixing Criteria typecast support when target type…

f06c223

… is a number

[WIP][OPENJPA-2940] Avoiding tests of criteria typecasts in unsupport…

d6ffe7c

…ing db (derbydb)

[WIP][OPENJPA-2940] Implements string LEFT and RIGHT string functions

4ec8d48

[WIP][OPENJPA-2940] Remove LEFT and RIGHT tests for derbydb (does not…

1831cd4

… support them)

[WIP][OPENJPA-2940] Removing still unimplemented Replace call

44ffe79

[WIP][OPENJPA-2940] Adding REPLACE JPQL function and Criteria

4fc3260

[WIP][OPENJPA-2940] Adding JPQL syntax support for ID and VERSION

bb2bc00

[OPENJPA-2940] bval is reverted

7335e0b

rzo1 and others added 2 commits July 17, 2026 08:41

[OPENJPA-2940] Tolerate update count 0 on DELETE only for entities wi…

88cfca0

…thout a version, so optimistic lock failures still surface Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

[OPENJPA-2940] mysql TCK

7cbef20

cristof added 2 commits July 17, 2026 08:38

[OPENJPA-2940] Fixes TestBiDirectionalJoinTable checks statements whe…

5b6bcca

…n running on Oracle

[OPENJPA-2940] Makes OracleDictionary support column options DDL

1cb05eb

[OPENJPA-2940] Updating documentation to reflect JPA-3.2

f672038

[OPENJPA-2940] scripts are simplified

8b559b6

solomax approved these changes Jul 21, 2026

View reviewed changes

rmannibucau reviewed Jul 30, 2026

View reviewed changes

cristof and others added 9 commits July 30, 2026 18:34

[OPENJPA-2940] Fixes RIGHT and LEFT in-memory JPA environment

af929b9

LEFT and RIGHT now mimic behavior of PostgreSQL equivalent functions

[OPENJPA-2940] Fixes typos in BrokerFactory

cbb19f7

[OPENJPA-2940] Pin GitHub Actions to commit SHAs

79af2a7

[OPENJPA-2940] Update TCK README to match run-tck32.sh and drop stale…

562c90d

… gitignore entries

[OPENJPA-2940] Restore autoCommit and release the connection in Store…

88e7709

…dProcedureQuery

[OPENJPA-2940] Unwrap nested pcsubclass names in ImplHelper.getEntity…

2a8d383

…Class via PCEnhancer.isPCSubclassName

[OPENJPA-2940] Adds some tests to cover REPLACE, RIGHT, LEFT and CAST…

a0f9293

…s in in-memory JPAs

[OPENJPA-2940] Makes 'replace' a valid path_component

770405c

Uh oh!

Conversation

cristof commented May 16, 2026

Uh oh!

rzo1 commented Jul 17, 2026

Uh oh!

solomax commented Jul 17, 2026

Uh oh!

rzo1 commented Jul 17, 2026

Uh oh!

solomax commented Jul 17, 2026

Uh oh!

rzo1 commented Jul 17, 2026

Uh oh!

solomax commented Jul 17, 2026

Uh oh!

cristof commented Jul 17, 2026

Uh oh!

solomax commented Jul 18, 2026

Uh oh!

rzo1 commented Jul 21, 2026

Uh oh!

solomax left a comment

Choose a reason for hiding this comment

Uh oh!

cristof commented Jul 21, 2026

Uh oh!

cristof commented Jul 30, 2026

Uh oh!

rmannibucau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rmannibucau Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rmannibucau Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

solomax Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

rmannibucau Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

solomax Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rmannibucau Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

rmannibucau Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

rmannibucau left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

solomax Aug 3, 2026 •

edited

Loading