Repository navigation
Conversation
Contributor
Author
|
ohh, the new clippy warning, I don't want to fix them in this pr. |
Contributor
Author
|
asukaminato0721
marked this pull request as ready for review
August 7, 2025 18:15
Member
This has already been resolved and merged into main. |
asukaminato0721
force-pushed
the
root-path
branch
from
August 8, 2025 08:46
c9d609b to
4846eb3
Compare
Xuanwo
reviewed
Aug 8, 2025
Contributor
Author
PyErr { type: <class 'TypeError'>, value: TypeError("'PosixPath' object cannot be converted to 'PyString'"), traceback: None }Need some fix. |
Xuanwo
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6479.
Rationale for this change
Passing
pathlib.PathasrootraisesTypeErrorin the Python operator constructors because keyword values must be strings.What changes are included in this PR?
Both
OperatorandAsyncOperatoraccept strings and path-like keyword values whoseos.fspath()result is a string. The constructor annotations and docstrings describePathLike[str]. Regression tests exercise synchronous and asynchronous Fs writes and reads with string andPathroots, and reject bool and bytes values.Validation on Nier: 19 focused constructor,
from_config, andfrom_uricases against the newly built native extension, plus Rust and Python quality checks and regenerated-stub consistency.Are there any user-facing changes?
Callers can pass
pathlib.Pathand otherPathLike[str]values directly to either constructor.Breaking changes
AI Usage Statement
gpt-6.1-sol. Effort:max. Role: constructor implementation, regression tests, and integration.group/deepseek(underlying model version is not exposed). Effort:max. Role: independent source review and validation on Nier.