Skip to content

tools/refresh.sh: Accept defconfig path as argument - #20096

Open
ajuckler wants to merge 1 commit into
apache:masterfrom
ajuckler:refresh_file
Open

tools/refresh.sh: Accept defconfig path as argument#20096
ajuckler wants to merge 1 commit into
apache:masterfrom
ajuckler:refresh_file

Conversation

@ajuckler

@ajuckler ajuckler commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Modify refresh.sh to also accept defconfig file path(s) as argument
  • Update outdated documentation

Impact

No direct impact, current functionalities are preserved

Testing

Run following 2 commands with attached output

$ ./tools/refresh.sh --defaults chip:stm32f7 
Normalizing all boards in chip: stm32f7 !
  [1/34] Normalize steval-eth001v1/foc_f32
  [2/34] Normalize steval-eth001v1/foc_b16
  [3/34] Normalize steval-eth001v1/nsh
  [4/34] Normalize stm32f769i-disco/netnsh
  [5/34] Normalize stm32f769i-disco/nsh
  [6/34] Normalize nucleo-f746zg/pysim
  [7/34] Normalize nucleo-f746zg/note
  [8/34] Normalize nucleo-f746zg/lorawan_gw
  [9/34] Normalize nucleo-f746zg/nsh
  [10/34] Normalize nucleo-f746zg/evalos
  [11/34] Normalize stm32f777zit6-meadow/projectlab
  [12/34] Normalize stm32f777zit6-meadow/sdram
47d46
< CONFIG_TESTING_RAMTEST=y
Save the new configuration (y/N)?y
Saving the new configuration file
  [13/34] Normalize stm32f777zit6-meadow/dualcdcacm
  [14/34] Normalize stm32f777zit6-meadow/f7corecomp
  [15/34] Normalize stm32f777zit6-meadow/nsh
  [16/34] Normalize stm32f777zit6-meadow/usbnsh
  [17/34] Normalize stm32f777zit6-meadow/meadow_os
  [18/34] Normalize stm32f777zit6-meadow/i2s
  [19/34] Normalize nucleo-f767zi/netnsh
  [20/34] Normalize nucleo-f767zi/nsh
  [21/34] Normalize nucleo-f767zi/evalos
  [22/34] Normalize stm32f746-ws/nsh
  [23/34] Normalize stm32f746g-disco/fb
  [24/34] Normalize stm32f746g-disco/dropbear
62,63d61
< CONFIG_NETUTILS_DROPBEAR=y
< CONFIG_NETUTILS_DROPBEAR_HOSTKEY_PATH="/data/dropbear_ecdsa_host_key"
74d71
< CONFIG_NSH_DROPBEAR=y
Save the new configuration (y/N)?y
Saving the new configuration file
  [25/34] Normalize stm32f746g-disco/nxterm
  [26/34] Normalize stm32f746g-disco/lvgl
  [27/34] Normalize stm32f746g-disco/nxdemo
  [28/34] Normalize stm32f746g-disco/netnsh
  [29/34] Normalize stm32f746g-disco/audio
  [30/34] Normalize stm32f746g-disco/nsh
  [31/34] Normalize nucleo-f722ze/composite
  [32/34] Normalize nucleo-f722ze/cansock
  [33/34] Normalize nucleo-f722ze/can
  [34/34] Normalize nucleo-f722ze/nsh
$ ./tools/refresh.sh --defaults boards/arm/stm32f1/stm32f103-minimum/configs/nsh/defconfig
 [1/1] Normalize boards/arm/stm32f1/stm32f103-minimum/configs/nsh/defconfig

@ajuckler
tools/refresh.sh: Accept defconfig path as argument
8c3535e 
* Modify refresh.sh to also accept path to defconfig file(s) as argument
* Update outdated script documentation and add the new argument

Signed-off-by: Antoine Juckler <6445757+ajuckler@users.noreply.github.com>
@github-actions github-actions Bot added Area: Build system Size: M The size of the change in this PR is medium labels Sep 9, 2026
xiaoxiang781216
xiaoxiang781216 reviewed Sep 9, 2026
View reviewed changes
Comment thread Documentation/components/tools/refresh.rst
tools/refresh.sh is a tool for refreshing board configurations

USAGE: tools/refresh.sh [options] <board>:<config>+
[options] <defconfig>+

@xiaoxiang781216 xiaoxiang781216 Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the origin code already support /path/to/defconfig, why do we need add /path/to?

@ajuckler ajuckler Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you mean the opposite: current code supports /path/to but not /path/to/defconfig.
Honestly I didn't notice...

For background, I'm trying to refresh an out-of-tree configuration so I cannot use the <board>:<config> format. When I tried path/to/defconfig it failed so I modified the script to accept this type of argument as well. Supporting the full path doesn't seem harmful, but I can revert the changes in refresh.sh and only update the doc if you prefer.

@xiaoxiang781216 xiaoxiang781216 Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, let's provide one method, but documentation it

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 left review comments
@acassis acassis acassis approved these changes
@jerpelea jerpelea jerpelea approved these changes

Assignees

No one assigned

Labels

Area: Build system Size: M The size of the change in this PR is medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ajuckler @acassis @jerpelea @xiaoxiang781216