Enable loading of bundles importing java.-packages and update Bouncy Castle to fix jgit signing#9329
Merged
matthiasblaesing merged 2 commits intoapache:masterfrom Apr 12, 2026
Conversation
matthiasblaesing
added
ci:all-tests
matthiasblaesing
force-pushed
the
bouncy_castle_update
branch
from
b73161f to
8d46f6c
Compare
Member
|
refreshed #8892 and temporarily added this PR to it to test everything together with jgit 7.4. edit: smoke test worked, modules loaded + tested basic git workflow |
matthiasblaesing
force-pushed
the
bouncy_castle_update
branch
3 times, most recently
from
a254fe1 to
59c58a0
Compare
matthiasblaesing
changed the title
mbien
reviewed
Apr 12, 2026
mbien
added
Upgrade Library
mbien
reviewed
Apr 12, 2026
Member
mbien
left a comment
mbien
left a comment
There was a problem hiding this comment.
changes look good. Checked the dependency tree for the new versions and nothing changed there.
osgi.nb10 probably needs its final hosting location still
Newer bouncy castle JARs declare an import of the java.io package. This is rejected by the manifest verification in the equinox version NetBeans uses wrapped into Netbinox. This change deactivates the check in equinox that rejects that entry. Additionally the instructions for building the patched equinox version were updated. Closes: apache#8894
matthiasblaesing
force-pushed
the
bouncy_castle_update
branch
from
59c58a0 to
86d59af
Compare
mbien
approved these changes
Apr 12, 2026
Contributor
Author
Valid point - I wanted to wait with moving to final hosting until this got some opinion apart from mine. Uploaded the artifact to osuosl and updated the corresponding commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jgit signing requires bouncy castle libraries with a version higher equal to or higher than 1.79.
Recent versions of bouncy castle declare an import package:
which is rejected by the NetBeans bundled equinox version. The validation provided by this version rejects alls
java.*imports. This PR removes that check and updates bouncy castle to 18.3.Closes: #8894
Closes: #8776