Conversation
Maven Resolver Provider "completes" the Maven Resolver, and it should not be other way around. Changes: * drop completely maven-resolver-supplier-mvn3 from dependencies * copy paste 3 classes to package o.a.m.r.supplier; basically maven-resolver-provider "defines" Resolver version * drop all the legacy; reusing apache#13259
|
@fridrich ping |
I look at it and when I was analyzing what to bring back the Maven3ScopeManagerConfiguration.java was looking to me as a dead weight. Besides that, whatever makes this less circular, I am fine with it. Since this PR exists, I added to my original one also the follow-up commit, where I only brought back the maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenSessionBuilderSupplier.java from your referenced commit. All the other things, I left them as they were. But I did not really give it a huge analysis. Just that it built and passed all tests. |
rmannibucau
left a comment
rmannibucau
left a comment
There was a problem hiding this comment.
FTR we should find a way to ignore getArtifactTypeRegistry but not worse than today
|
Yeah, we should align these... |
4 participants
Maven Resolver Provider "completes" the Maven Resolver, and it should not be other way around.
Changes:
This basically aligns Maven 3.10 with Maven 4, as latter also carries "own" suppliers.
Co-authored-by: Fridrich Strba fridrich.strba@bluewin.ch