Conversation
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
A couple of observations on this one-line change:
-
The
<!--item name="FAQ" href="faq.html"/-->line has been commented out since June 2011 (commit 799d63b by Hervé Boutemy). After 15+ years of dormancy, removing the dead line entirely would be a cleaner approach than annotating it with a second comment — the existing XML is already self-documenting. -
The PR body references "Fixes #9" but PR/issue #9 is "[MNG-5513] Artifact filtering not updated for Eclipse Aether filtering" — an unrelated, already-merged change. This reference should be removed.
The change itself is harmless, but adding a comment to 15-year-old dead code is debatable when deletion would be simpler.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
elharo
changed the title
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
The author addressed our previous feedback — the dead commented-out FAQ link (dormant since 2011) is now removed entirely rather than annotated. Clean improvement.
Minor nit (non-blocking): The removal replaces the commented-out line with a blank line containing trailing whitespace. Ideally squash that blank line out entirely for a cleaner diff.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Re-reviewed after the new commit (360425d0 — Remove blank line in site.xml menu section). The change is a clean whitespace cleanup removing the blank line left behind after deleting the commented-out FAQ link. No issues — still looks good.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
2 participants
Fixes #9.