Conversation
Restores the previous session after execution instead of unconditionally setting it to null.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how DefaultMaven manages LegacySupport’s current MavenSession, moving from a top-level “clear on exit” approach to a scoped save/restore pattern inside doExecute(...). This is intended to prevent session leakage/corruption in scenarios like nested executions and to better encapsulate session lifecycle handling within the session scope.
Changes:
- Removed the
execute()-levelfinally { legacySupport.setSession(null); }cleanup. - Introduced save/restore of the previous
LegacySupportsession around the maindoExecute(request, session, ...)call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
223
to
+227
| legacySupport.setSession(session); | ||
|
|
||
| return doExecute(request, session, result, chainedWorkspaceReader); | ||
| try { | ||
| return doExecute(request, session, result, chainedWorkspaceReader); | ||
| } finally { | ||
| legacySupport.setSession(previousSession); |
Comment on lines
+222
to
+225
| MavenSession previousSession = legacySupport.getSession(); | ||
| legacySupport.setSession(session); | ||
|
|
||
| return doExecute(request, session, result, chainedWorkspaceReader); | ||
| try { | ||
| return doExecute(request, session, result, chainedWorkspaceReader); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12594