Skip to content

Ensure MavenProject#getPluginManagement never returns null#12010

Merged
slawekjaranowski merged 1 commit intoapache:maven-3.10.xfrom
slawekjaranowski:project-plugin-managment-not-null
May 2, 2026
Merged

Ensure MavenProject#getPluginManagement never returns null#12010
slawekjaranowski merged 1 commit intoapache:maven-3.10.xfrom
slawekjaranowski:project-plugin-managment-not-null

Conversation

@slawekjaranowski
Copy link
Copy Markdown
Member

When we have pluginManagement in Super POM - MavenProject#getPluginManagement never returns null, should be the same after removing pluginManagement.

It can break the plugin which can assume that it is not null.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

When we have `pluginManagement` in Super POM - MavenProject#getPluginManagement never returns null,
should be the same after removing `pluginManagement`.

It can break the plugin which can assume that it is not null.
@slawekjaranowski slawekjaranowski added this to the 3.10.0 milestone May 1, 2026
@slawekjaranowski slawekjaranowski added the bug Something isn't working label May 1, 2026
@slawekjaranowski slawekjaranowski merged commit 835209b into apache:maven-3.10.x May 2, 2026
18 checks passed
@slawekjaranowski slawekjaranowski deleted the project-plugin-managment-not-null branch May 2, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants