Skip to content

Fix IT failures on Maven 4 (transporter: NoTransporterException for file:// protocol) #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elharo wants to merge 4 commits into from
Closed

Fix IT failures on Maven 4 (transporter: NoTransporterException for file:// protocol) #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b152dc8
Fix IT failures on Maven 4: add wagon transport and update deploy plu…
elharo Jul 20, 2026
5612acd
Add jar:jar goal to reproducible IT so deploy:deploy has a main artifact
elharo Jul 20, 2026
3c734a2
Add maven-fluido-skin to site.xml to fix 'skin cannot be null' with M…
elharo Jul 20, 2026
dc0afe7
Merge branch 'master' into master
elharo Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ under the License.
<goal>install</goal>
</goals>
<addTestClassPath>true</addTestClassPath>
<mavenOpts>-Dmaven.resolver.transport=wagon</mavenOpts>

@slawekjaranowski slawekjaranowski Jul 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be careful with such change .... it turn on old transport which is not used by default
In real use users use default transport so problem can be only hidden here and we test something different which is normally used

@elharo elharo Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is necessary to make the existing tests pass because they use file:// URLs the default transport doesn't support. Perhaps file an issue to fix those tests. However, in the meantime I think it is absolutely essential to get the tests passing. No progress on anything can be made until we do that, and this is the minimal and safest change I could contrive that accomplishes that. Once the CI is green, we can carefully move forward with other fixes without fear of accidentally breaking more things.

The alternative would be to roll everything back to the last known good commit.

@ascheman ascheman Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I suggest to focus on the root cause (-> #310) to make CI green again and leave the transport fix (and clarification of #309 (comment)) for the time beyond merging #268 (which could be prepared nonetheless).

</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion src/it/reproducible/invoker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.

invoker.goals=remote-resources:process source:jar deploy:deploy
invoker.goals=remote-resources:process jar:jar source:jar deploy:deploy
2 changes: 1 addition & 1 deletion src/it/reproducible/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<version>2.8.2</version>
<version>3.1.4</version>
<configuration>
<!-- Deployments will be written to ${basedir}/target -->
<altDeploymentRepository>mine::default::file://${basedir}/target/repo</altDeploymentRepository>
Expand Down
Loading