fix #87: null-check getTargetFiles() return value - #102
Open
elharo wants to merge 2 commits into
Open
Conversation
- Skip mappings that return null from getTargetFiles() - Add test for null return from SourceMapping
There was a problem hiding this comment.
Pull request overview
This PR fixes an NPE in StaleResourceScanner by tolerating SourceMapping#getTargetFiles(...) implementations that return null, aligning behavior with Issue #87’s reported failure mode.
Changes:
- Add a null-check in
StaleResourceScanner#getIncludedSources(...)to skip mappings that returnnullfromgetTargetFiles(). - Add a JUnit test covering the “
getTargetFiles()returns null” scenario to prevent regressions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/org/apache/maven/shared/io/scan/StaleResourceScanner.java | Skips SourceMapping entries that return null target file sets, preventing NPE during iteration. |
| src/test/java/org/apache/maven/shared/io/scan/StaleResourceScannerTest.java | Adds a regression test exercising the null-return behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip SourceMapping entries that return null from getTargetFiles() instead of throwing NPE.
Fixes #87