fix #86: null stream and channel after close() to allow re-open - #101
Open
elharo wants to merge 1 commit into
Open
fix #86: null stream and channel after close() to allow re-open#101elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
- After close(), set channel and stream to null so open() can re-initialize - Add test for read-close-reopen-read
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #86 where FileLocation could not be used again after close() because the internal stream/channel references remained non-null (but closed), preventing open() from reinitializing them.
Changes:
- Reset
channelandstreamtonullat the end ofFileLocation.close()soopen()can re-create them on subsequent reads. - Add a regression test verifying that
FileLocationcan be opened/read again after being closed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/org/apache/maven/shared/io/location/FileLocation.java | Nulls out channel/stream after closing to allow re-open via open()/read(). |
| src/test/java/org/apache/maven/shared/io/location/FileLocationTest.java | Adds a test covering the re-open-after-close scenario to prevent regressions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After close(), set channel and stream to null so that open() can re-initialize them on subsequent read calls.
Fixes #86