Fix inverted SIGTSTP condition in IPC server#1915
Merged
Merged
Conversation
The condition for ignoring SIGTSTP was inverted: it tried to ignore TSTP on Windows (where it does not exist, causing a crash) and did nothing on Unix (where TSTP exists, causing the daemon to suspend on Ctrl-Z). Fix: ignore SIGTSTP only on non-Windows (Unix) systems.
cstamas
approved these changes
Jun 9, 2026
gnodet
changed the title
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition for ignoring SIGTSTP in
IpcServer.main()was inverted:if (IpcClient.IS_WINDOWS)tried to register a SIGTSTP handler on Windows, where the signal does not exist — causing a crash at daemon startup.Fix: Negate the condition to
if (!IpcClient.IS_WINDOWS)so that SIGTSTP is ignored on Unix only.This is a one-character fix (
!added) with no behavioral change on any OS other than making things work correctly: