Skip to content

Narrow catch clause in createArchive() #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elharo wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Narrow catch clause in createArchive() #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import org.apache.maven.shared.model.fileset.FileSet;
import org.apache.maven.shared.model.fileset.util.FileSetManager;
import org.codehaus.plexus.archiver.Archiver;
import org.codehaus.plexus.archiver.ArchiverException;
import org.codehaus.plexus.archiver.jar.JarArchiver;

/**
Expand Down Expand Up @@ -282,14 +283,13 @@
getLog().warn("JAR will be empty - no content was marked for inclusion!");
}
} else {
archiver.getArchiver().addDirectory(contentDirectory.toFile(), getIncludes(), getExcludes());

Check warning on line 286 in src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 4.0.0-rc-4 

addDirectory(java.io.File,java.lang.String[],java.lang.String[]) in org.codehaus.plexus.archiver.AbstractArchiver has been deprecated

Check warning on line 286 in src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 4.0.0-rc-4 

addDirectory(java.io.File,java.lang.String[],java.lang.String[]) in org.codehaus.plexus.archiver.AbstractArchiver has been deprecated

Check warning on line 286 in src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-17-zulu 4.0.0-rc-4 

addDirectory(java.io.File,java.lang.String[],java.lang.String[]) in org.codehaus.plexus.archiver.AbstractArchiver has been deprecated

Check warning on line 286 in src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 4.0.0-rc-4 

addDirectory(java.io.File,java.lang.String[],java.lang.String[]) in org.codehaus.plexus.archiver.AbstractArchiver has been deprecated
}

archiver.createArchive(session, project, archive);

return jarFile;
} catch (Exception e) {
// TODO: improve error handling
} catch (MavenArchiverException | ArchiverException e) {
throw new MojoException("Error assembling JAR", e);
Comment on lines +292 to 293
}
}
Expand Down
Loading