Skip to content

Fix effective-pom_properties IT for Maven 4 compatibility #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ascheman wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

Fix effective-pom_properties IT for Maven 4 compatibility #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/it/projects/effective-pom_properties/invoker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@
# under the License.

invoker.goals = ${project.groupId}:${project.artifactId}:${project.version}:effective-pom

@slawekjaranowski slawekjaranowski Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^M ... looks like problem with file encoding

@hboutemy hboutemy Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, no encoding, but Windows newline!


# verify.groovy asserts that user properties override pom properties on Maven 4,
# expecting maven.compiler.source/target = 8 in the rendered effective POM.
# Pass them as -D user properties so the override actually happens.
invoker.systemProperties.maven.compiler.source = 8
invoker.systemProperties.maven.compiler.target = 8
Loading