Put multi-release sibling output directories on the module path - #1139
Draft
slachiewicz wants to merge 1 commit into
Draft
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
javac reads an exploded module only from its root, so the META-INF/versions/<N> directory goes on the module path and the output directory patches the module. Needs plexus-java with codehaus-plexus/plexus-languages#236.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1137. A reactor sibling built with
multiReleaseOutputhas itsmodule-info.classonly underMETA-INF/versions/<N>until it is packaged, and javac reads an exploded module only from its root. Such a directory is now replaced on the module path by its versioned descriptor directory and patches its module with--patch-module, in bothcompileandtestCompile, somvn compileandmvn testwork withoutpackage.Depends on codehaus-plexus/plexus-languages#236, which lets plexus-java recognise the directory as a module;
plexus-java.versiongets bumped to that release before this leaves draft. The descriptor version followsrelease, thentarget; making plexus-java use the same version is #1138.Verified against plexus-java 1.6.1-SNAPSHOT:
mvn -Prun-its verify→ 81 ITs pass; the new IT fails withmodule not foundwithout the change.