Skip to content

[MCOMPILER-595] Enable parameter metadata by default #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilx wants to merge 1 commit into from
+10 −11
Closed

[MCOMPILER-595] Enable parameter metadata by default #1090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/it/MCOMPILER-298/invoker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@
# under the License.

invoker.goals = test
invoker.goals.2 = clean test -Dmaven.compiler.parameters=false -DexpectedParameterNamePresent=false
3 changes: 0 additions & 3 deletions src/it/MCOMPILER-298/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>@project.version@</version>
<configuration>
<parameters>true</parameters>
</configuration>
</plugin>
</plugins>
</build>
Expand Down
12 changes: 6 additions & 6 deletions src/it/MCOMPILER-298/src/test/java/com/foo/ParameterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ public class ParameterTest {

@Test
public void testParameter() throws Exception {
assertEquals(
"parameterName",
ParameterClass.class
.getMethod("method", String.class)
.getParameters()[0]
.getName());
var parameter = ParameterClass.class.getMethod("method", String.class).getParameters()[0];
boolean expectedNamePresent = Boolean.parseBoolean(System.getProperty("expectedParameterNamePresent", "true"));
assertEquals(expectedNamePresent, parameter.isNamePresent());
if (expectedNamePresent) {
assertEquals("parameterName", parameter.getName());
}
}
}
5 changes: 3 additions & 2 deletions src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,12 +447,13 @@ final Charset charset() {
/**
* Whether to generate metadata for reflection on method parameters.
* If {@code true}, the {@code -parameters} option will be added to compiler arguments.
* This is enabled by default. Set this parameter to {@code false} to omit the metadata.
*
* @see <a href="https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-parameters">javac -parameters</a>
* @since 3.6.2
*/
@Parameter(property = "maven.compiler.parameters", defaultValue = "false")
protected boolean parameters;
@Parameter(property = "maven.compiler.parameters", defaultValue = "true")
protected boolean parameters = true;

/**
* Whether to include debugging information in the compiled class files.
Expand Down