Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR hinges on acceptance of both companion PRs:
The development dependencies use their snapshots. We will replace them with concrete releases when those releases are available.
Changes
Enables TAR hard-link preservation through the existing
archiverConfigparameter with<preserveHardLinks>true</preserveHardLinks>. Preservation is disabled by default. Eligible untransformed resources share one payload, with subsequent entries pointing backward to the first entry's final mapped archive name. Filtering, line-ending transformations, unrelated files with matching bytes, and incompatible output metadata keep independent contents.Covers plain TAR and the gzip, bzip2, xz, Snappy, and Zstandard TAR formats. The integration fixture checks default, explicitly disabled, and enabled configurations, mapped names, contents, and inode relationships.
Adopts Plexus Archiver 5, raises the runtime requirements to Java 17 and Maven 3.9.6, updates the CI JDK matrix and requirements history, and migrates
AssemblyProxyArchiverto the current resource, file-set, andFileTimeAPIs. Documents the required migration and recompilation of custom handlers using removed Archiver APIs.Validation
Archiverinterface also passed.Validation used IO
8cf1d9aand local Archiver3e29b954, including the extraction-hook compatibility follow-up. That Archiver follow-up is not yet published in #493, whose current head is4b2cc87d.Validation covers Linux. The full Assembly integration suite, Windows, and macOS were not run.
Checklist
Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
Run
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
You have run the integration tests successfully (
mvn -Prun-its verify).The focused integration scenarios listed above passed; the full suite was not run.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.