fix: prevent NPE in ManifestConfiguration.getClasspathPrefix() when prefix is null - #381
Merged
Merged
Conversation
…refix is null The setter now treats null as the empty string, consistent with the field's default value. This prevents a NullPointerException in getClasspathPrefix() when callers pass null (e.g., from unset XML configuration elements). Fixes apache#367
elharo
force-pushed
the
fix-367-npe-classpath-prefix
branch
from
July 4, 2026 13:06
dbe9d8c to
ac18752
Compare
ascheman
approved these changes
Aug 4, 2026
ascheman
left a comment
ascheman
left a comment
There was a problem hiding this comment.
LGTM. The NPE came from the setter storing a caller's null as-is, which then hit getClasspathPrefix()'s replaceAll. Guarding it in the setter (null → "") is the right layer — it restores the field's non-null invariant (it already defaults to ""), so the getter is always safe, and getClasspathPrefix() is the only getter here that manipulates the string, so no sibling field is left exposed. The added getClasspathPrefixShouldHandleNull() test locks it in. Thanks @elharo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #367.
Problem:
ManifestConfiguration.getClasspathPrefix()calls.replaceAll()on the field without a null check. The field is initialized to"", but the setter stores the value as-is. If any caller passesnull(e.g., from unset XML configuration elements mapped via Plexus), the getter throws NPE.Fix: Guard
setClasspathPrefix()against null, falling back to"".Test: Added
getClasspathPrefixShouldHandleNull().