Repository navigation
test(agent): update cancellation fixture to use Maka preferences - #6664
Merged
Merged
Conversation
Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #6655 delegated project rule-file loading to native CLIs, the cancellation test still changed the workspace's
AGENTS.mdto trigger a Maka instruction update. The update no longer occurred, so the fixture reportedopenedinstead ofbefore_instructions_ackand failed baseline CI.Create
.makain the fixture's configured instruction home and change.maka/AGENTS.mdinstead. Keep the existing cancellation, confirmed-digest, native-session identity and retry assertions for Codex, Antigravity and Claude. Production behavior and test timeouts are unchanged.Refs #6655.
Verification
rust-preview@72162299fa: expectedbefore_instructions_ack, receivedopened, matching baseline CI.maka-agent-nativelibrary tests passed withcargo nextest: instruction-ack cancellation, all-protocol instruction updates/session reuse, skill instruction replacement/clearing, and global instruction selection/admission. These use local protocol fixtures, not live vendor CLIs.cargo fmt --all -- --checkandgit diff --checkpassed.cargo clippy --locked -p maka-agent-native --tests --no-deps -- -D warningsreported three existing warnings inowner/assistant.rsandowner/tests/session_parent_authority.rs; both files are identical to the base. The same check passed with onlyclippy::collapsible_ifandclippy::needless_borrows_for_generic_argsallowed on the command line. No lint configuration was changed.AI use
Tool(s) and scope: Codex diagnosed the failure, updated the test fixture, ran focused verification and drafted this PR.
Checklist
Formatting and focused tests pass; the strict Clippy baseline exception is described above.
Does this PR entail a change in behavior?