Repository navigation
test(desktop): reveal the models row before pressing it in narrow layouts - #6660
UncertaintyDeterminesYou4ndMe wants to merge 1 commit into
Conversation
…outs Since #6609 added the server-side compaction toggle, the models row of the connection settings page starts under the fixed footer in the narrow visual cases (720px), so the test pressed the footer and failed with "no single control labelled Edit model gpt-4.1". Scroll the page until the row ends above the footer before pressing it. The wide cases need no scroll and are unchanged. Generated-by: Claude Code
Astro-Han
left a comment
There was a problem hiding this comment.
I reviewed the complete one-file change and the surrounding control, press, retry, pump and model-settings test flow. press clicks a control's center, so a row whose center lies beneath the fixed connection footer can miss its intended target. The new helper waits until the row's bottom is above the footer, sends a downward wheel event in the scrollable area, and then uses the existing press operation. An already-clear wide layout returns without scrolling. The following assertions still require the model editor, default-model persistence and the later settings workflow; the fix does not remove assertions or raise timeouts.
I found no confirmed P0–P2 issue in this change. It merges cleanly with rust-preview@72162299; CI 42159356945 was queued when checked. The author's successful four visual cases and failing narrow-layout control are author-reported results: I did not execute GPUI, generate screenshots, or independently reproduce the narrow click. My validation here is source-level. No production behavior, protocol, dependency or database migration changes.
Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.
desktop_model_settings_keeps_successful_sign_in_and_retries_modelsfails in the narrow visual cases (MAKA_UI_VISUAL_CASE=light-narrowordark-narrow) with "no single control labelled Edit model gpt-4.1". CI runs onlydark-wide, so it shows up only when generating screenshots.Since #6609 added the "Provider server-side compaction" toggle, the connection page in a 720×720 window has the "Manage models" row half under the fixed footer. The test pressed the row's centre, which is on the footer, so the models page never opened. The test now scrolls the page until the row ends above the footer before pressing it (
reveal_above, built on a smallscroll_atwheel helper). The wide cases are already clear of the footer and do not scroll.On 7216229 the test fails in
light-narrowwithout the change and passes in all four visual cases with it.AI use
Tool(s) and scope: Claude Code found the failure while checking the narrow screenshots, wrote the change and this description; the commit carries
Generated-by: Claude Code.