Skip to content

fix(settings): make provider sign-in and model editing reliable #6517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
M4n5ter merged 3 commits into from
Nov 1, 2026
Merged

fix(settings): make provider sign-in and model editing reliable #6517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
526114a
fix(settings): make provider sign-in and model editing reliable
M4n5ter Nov 1, 2026
787ea72
fix(settings): complete provider picker interactions and presentation
M4n5ter Nov 1, 2026
d9e51f0
fix(settings): localize built-in provider display and search labels
M4n5ter Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/plugin-sdk/src/contracts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40942,6 +40942,9 @@ export const contracts = {
SettingsProviderSummary: {
type: 'object',
properties: {
customEndpoint: {

@Astro-Han Astro-Han Nov 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Refresh the source-bound release inventory with this SDK change

products/maka/cli/notices.json still records the old bytes of this file and src/generated/runtime.ts. The actual notice verifier passes on the pre-PR base 167ce25f and fails on the final head; changing only those two fingerprints in a disposable copy makes it pass again. The merged Rust CI stops in notices.test.mjs with this same error, and release preparation also calls verifyNotices. Regenerate and review the notice inventory for the final inputs so these SDK updates do not leave normal checks and packaging blocked.

Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.

type: 'boolean',
},
identity: {
$ref: '#/$defs/Identity',
},
Expand All @@ -40956,7 +40959,7 @@ export const contracts = {
},
},
additionalProperties: false,
required: ['identity', 'label', 'authentication'],
required: ['customEndpoint', 'identity', 'label', 'authentication'],
},
Identity: {
description:
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-sdk/src/generated/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6858,6 +6858,7 @@ export interface SettingsProvidersPage {
next: number | null;
}
export interface SettingsProviderSummary {
customEndpoint: boolean;
identity: Identity;
label: string;
authentication: SettingsProviderAuthenticationSummary[];
Expand Down
1 change: 1 addition & 0 deletions plugins/settings/native/src/connections.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ pub(crate) fn providers(input: Value, snapshot: Arc<Snapshot>) -> Result<Value,
let provider = definition(&identity, snapshot.clone())?;
let descriptor = provider.descriptor();
let summary = ProviderSummary {
custom_endpoint: descriptor.custom_endpoint,
identity,
label: descriptor.label.clone(),
authentication: descriptor
Expand Down
3 changes: 2 additions & 1 deletion plugins/settings/native/src/contract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,10 @@ pub struct ProviderAuthenticationSummary {
pub interactive: bool,
}
#[derive(Serialize, JsonSchema)]
#[serde(deny_unknown_fields)]
#[serde(rename_all = "camelCase", deny_unknown_fields)]
#[schemars(rename = "SettingsProviderSummary")]
pub struct ProviderSummary {
pub custom_endpoint: bool,
pub identity: maka_agent_facts::provider::Identity,
pub label: String,
pub authentication: Vec<ProviderAuthenticationSummary>,
Expand Down
Loading
Loading