Skip to content

test(desktop): stop the picker spec racing two upstream guards #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 2 commits into from
Aug 30, 2026
Merged

test(desktop): stop the picker spec racing two upstream guards #4225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
367202c
test(desktop): wait for the picker menu to open
orangeCatDeveloper Aug 29, 2026
686105e
test(desktop): type the draft at a human rate
orangeCatDeveloper Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions apps/desktop/e2e/new-task-draft-target.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import type { Page } from '@playwright/test';
import type { Locator, Page } from '@playwright/test';
import { COMPOSER_INPUT, NEW_TASK_PROJECT_NAME, expect, test } from './fixtures';

/**
Expand Down Expand Up @@ -50,6 +50,15 @@ async function settle(page: Page): Promise<void> {
);
}

// Picking an item hides the menu, and DropdownMenu then swallows a reopen
// click for 50ms.
async function openPicker(page: Page, picker: Locator): Promise<void> {
await expect(async () => {
await picker.click();
await expect(page.getByRole('menuitem').first()).toBeVisible({ timeout: 500 });
}).toPass({ timeout: 10_000 });
}

test('the new-task draft follows the Project chosen under the composer', async ({
newTaskTargetWindow: page,
}) => {
Expand All @@ -62,7 +71,9 @@ test('the new-task draft follows the Project chosen under the composer', async (
await expect(picker).toHaveAttribute('aria-label', new RegExp(NEW_TASK_PROJECT_NAME));

await composer.click();
await page.keyboard.type(DRAFT);
// Two keystrokes in one frame — no human rate — make ChatComposerInput
// rewrite the editor and reset the caret.
await page.keyboard.type(DRAFT, { delay: 20 });
await expect(composer).toHaveText(DRAFT);

await picker.click();
Expand All @@ -74,7 +85,7 @@ test('the new-task draft follows the Project chosen under the composer', async (
await settle(page);
await expect(composer).toHaveText(DRAFT);

await picker.click();
await openPicker(page, picker);
await page.getByRole('menuitem', { name: NEW_TASK_PROJECT_NAME, exact: true }).click();
await expect(picker).toHaveAttribute('aria-label', new RegExp(NEW_TASK_PROJECT_NAME));
await settle(page);
Expand Down