Skip to content

refactor: preserve Daily Review on shared authorities - #4178

Closed
Astro-Han wants to merge 21 commits into
apache:mainfrom
Astro-Han:refactor/daily-review-converge-scheduled-task
Closed

refactor: preserve Daily Review on shared authorities#4178
Astro-Han wants to merge 21 commits into
apache:mainfrom
Astro-Han:refactor/daily-review-converge-scheduled-task

Conversation

@Astro-Han

@Astro-Han Astro-Han commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Daily Review remains a first-class UI while its runtime uses shared authorities only:

  • ScheduledTask owns schedule, timezone, catch-up, and Run now.
  • Runtime Host ordinary Session / AgentRun / RuntimeEvent owns execution and recovery.
  • ordinary Session + Markdown Artifact owns reports and history.

The dedicated scheduler, resident state, model path, archive store/dashboard, protocol, and IPC are removed. The shared usage and model-call ledgers are unchanged. Net diff: 1,384 lines deleted.

UI comparison

Before After
Daily Review before visual simplification Daily Review after visual simplification

Migration and compatibility

  • Released file layouts (v0.1.0v0.1.3) and SQLite layouts migrate idempotently.
  • Existing deep reports become ordinary 7-day Session Artifacts; the retired deepEnabled schedule is not restored.
  • Archives migrate even when the old model is unavailable, then their legacy source is consumed once. Unreadable files are preserved in place.
  • Enabled config becomes the system preset task, or uses an existing runnable user Daily Review Agent task. Incompatible user tasks are left untouched and legacy config remains retryable.
  • Reports appear only after an ordinary Session is terminal and has a live Markdown Artifact.
  • Desktop bridge v2 gates the range-specific Run now prompt; Runtime Host compatibility epoch is 74.

Rollback after legacy retirement requires the pre-migration backup; migrated Sessions and Artifacts remain ordinary durable data.

Verification

  • 158 focused Core, Storage, Runtime Host, UI, and Desktop tests
  • affected workspace builds and typechecks
  • Biome lint/format and git diff --check

Full-repository tests were not run.

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Codex implemented the migration, authority convergence, UX preservation, tests, and review fixes. Material commits carry Generated-by: Codex trailers.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described above
  • No

@github-actions github-actions Bot added the effort/XL Over 1000 readable lines label Aug 29, 2026
@Astro-Han Astro-Han changed the title refactor: converge Daily Review on scheduled tasks refactor: preserve Daily Review on shared authorities Aug 29, 2026
@Astro-Han
Astro-Han force-pushed the refactor/daily-review-converge-scheduled-task branch 4 times, most recently from e2b99b6 to 51f2ab9 Compare August 29, 2026 17:40
Migrate legacy configuration and reports into the ScheduledTask, ordinary Session, and Artifact authorities, then remove the dedicated runtime and UI chain.

Generated-by: Codex
Keep Daily Review as a first-class Automations experience while projecting its schedule, execution, history, and reports from ScheduledTask, ordinary Session, Artifact, and the shared usage ledger.

Generated-by: Codex
Carry selected review ranges through ordinary ScheduledTask fire claims, keep paused schedules paused after manual runs, reject new Agent tasks without immutable Connection identity, and preserve the legacy one-time catch-up trigger during migration.

Generated-by: Codex
@Astro-Han
Astro-Han force-pushed the refactor/daily-review-converge-scheduled-task branch from 6af8a76 to b8d8c77 Compare August 30, 2026 06:04
@Astro-Han

Copy link
Copy Markdown
Contributor Author

Closing this draft because preserving the existing Daily Review contract would require rebuilding its range-bounded Session and Usage projection, fallback behavior, and legacy migration semantics on top of the shared runtime. That would defeat the simplification goal, so this implementation is not being proposed for merge.

@Astro-Han Astro-Han closed this Aug 30, 2026
@Astro-Han
Astro-Han deleted the refactor/daily-review-converge-scheduled-task branch August 30, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XL Over 1000 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant