refactor: preserve Daily Review on shared authorities - #4178
Closed
Astro-Han wants to merge 21 commits into
Closed
Conversation
Astro-Han
force-pushed
the
refactor/daily-review-converge-scheduled-task
branch
4 times, most recently
from
August 29, 2026 17:40
e2b99b6 to
51f2ab9
Compare
Migrate legacy configuration and reports into the ScheduledTask, ordinary Session, and Artifact authorities, then remove the dedicated runtime and UI chain. Generated-by: Codex
Keep Daily Review as a first-class Automations experience while projecting its schedule, execution, history, and reports from ScheduledTask, ordinary Session, Artifact, and the shared usage ledger. Generated-by: Codex
Carry selected review ranges through ordinary ScheduledTask fire claims, keep paused schedules paused after manual runs, reject new Agent tasks without immutable Connection identity, and preserve the legacy one-time catch-up trigger during migration. Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Astro-Han
force-pushed
the
refactor/daily-review-converge-scheduled-task
branch
from
August 30, 2026 06:04
6af8a76 to
b8d8c77
Compare
Generated-by: Codex
Contributor
Author
|
Closing this draft because preserving the existing Daily Review contract would require rebuilding its range-bounded Session and Usage projection, fallback behavior, and legacy migration semantics on top of the shared runtime. That would defeat the simplification goal, so this implementation is not being proposed for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily Review remains a first-class UI while its runtime uses shared authorities only:
ScheduledTaskowns schedule, timezone, catch-up, and Run now.The dedicated scheduler, resident state, model path, archive store/dashboard, protocol, and IPC are removed. The shared usage and model-call ledgers are unchanged. Net diff: 1,384 lines deleted.
UI comparison
Migration and compatibility
v0.1.0–v0.1.3) and SQLite layouts migrate idempotently.deepEnabledschedule is not restored.Rollback after legacy retirement requires the pre-migration backup; migrated Sessions and Artifacts remain ordinary durable data.
Verification
git diff --checkFull-repository tests were not run.
AI use
Codex implemented the migration, authority convergence, UX preservation, tests, and review fixes. Material commits carry
Generated-by: Codextrailers.Checklist
Does this PR entail a change in behavior?