Skip to content

fix(storage): widen the Windows ADS query timeout for cold Add-Type compiles #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Aug 27, 2026
+9 −1
Merged

fix(storage): widen the Windows ADS query timeout for cold Add-Type compiles #4041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/storage/src/managed-dependency-environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,15 @@ const MANAGED_DEPENDENCY_PRODUCER_POLICY_V1 = Object.freeze({
lifecycleScripts: 'disabled' as const,
});
const activeAuthorityOwners = new Map<string, object>();
const WINDOWS_STREAM_QUERY_TIMEOUT_MS = 30_000;
// Each query spawns a fresh powershell.exe that JIT-compiles the C# helper
// below via `Add-Type`. On a cold GitHub-hosted Windows runner that first
// compile (cold csc.exe launch + .NET Framework warmup) has been observed at
// ~31s, tripping a 30s budget while the following warm queries finish in 2-4s.
// The bounded, non-recursive walk cannot hang, so the timeout only exists to
// bound a wedged interpreter; give the cold compile generous headroom rather
// than misreport it as a wedge. The 45-minute job budget still bounds a true
// hang.
const WINDOWS_STREAM_QUERY_TIMEOUT_MS = 120_000;
const WINDOWS_STREAM_QUERY_MAX_OUTPUT_BYTES = 1024 * 1024;
const WINDOWS_STREAM_QUERY_SCRIPT = String.raw`
$ErrorActionPreference = 'Stop'
Expand Down