Honor spring.cloud.config.watch.enabled on Log4j2EventListener - #4252
Open
AzazelSensei wants to merge 1 commit into
Open
Honor spring.cloud.config.watch.enabled on Log4j2EventListener#4252AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
spring.factories constructs the listener outside the bean factory, so @ConditionalOnProperty never applies. Check the property in onApplicationEvent as well. Fixes apache#4244
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log4j2EventListeneris also created fromspring.factories, so@ConditionalOnPropertynever applies andspring.cloud.config.watch.enabled=falsedoes nothing.I check that property in
onApplicationEvent(viaEnvironmentAwareor the event source context). Explicitfalseskips the reload. Missing or true keeps the old behavior.Fixes #4244
Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (the build instructions)src/changelog/.2.x.xdirectory