Repository navigation
OAK-12513 : remove background write race in incremental store test - #3270
Open
rishabhdaim wants to merge 1 commit into
Open
rishabhdaim wants to merge 1 commit into
rishabhdaim wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rishabhdaim
requested review from
nit0906,
reschke,
thomasmueller and
tihom88
November 6, 2026 02:48
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fix a reproducible timing race in IncrementalStoreTest that caused the unrelated Elasticsearch dependency PR #3268 to fail.
Read-only stores initialize their root revision from persisted _lastRev values. The test relied on a 1 ms background writer publishing content before each reader opened; when publication lagged, the final export still contained the initial content.
Changes
Validation
Links
Co-Authored-By: GitHub Copilot copilot@github.com