Skip to content

OAK-12513 : remove background write race in incremental store test - #3270

Open
rishabhdaim wants to merge 1 commit into
trunkfrom
OAK-12513
Open

rishabhdaim wants to merge 1 commit into
trunkfrom
OAK-12513

Conversation

@rishabhdaim

Copy link
Copy Markdown
Contributor

Summary

Fix a reproducible timing race in IncrementalStoreTest that caused the unrelated Elasticsearch dependency PR #3268 to fail.

Read-only stores initialize their root revision from persisted _lastRev values. The test relied on a 1 ms background writer publishing content before each reader opened; when publication lagged, the final export still contained the initial content.

Changes

  • Explicitly run writer background operations after both content batches, before creating checkpoints and read-only stores.
  • Disable automatic background scheduling so the test no longer depends on thread timing.
  • Preserve all existing assertions and six compression/filter scenarios; no production code changes.

Validation

  • Reproduced the exact CI content mismatch by disabling background scheduling and publishing only the base content.
  • Ran all six IncrementalStoreTest scenarios in 20 separate Maven invocations: 120 executions, zero failures, errors or skips.
  • Full oak-run module suite: 223 tests, zero failures/errors, eight skipped.
  • Self-reviewed the complete diff; no additional findings.
  • git diff --check passed. Spotless could not run because the project does not configure that plugin.

Links

Co-Authored-By: GitHub Copilot copilot@github.com

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant