Skip to content

OAK-12022 : fix composite tests with pax exam 4.14.0 - #3247

Closed
rishabhdaim wants to merge 1 commit into
trunkfrom
OAK-12022
Closed

rishabhdaim wants to merge 1 commit into
trunkfrom
OAK-12022

Conversation

@rishabhdaim

@rishabhdaim rishabhdaim commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Enable parent-managed Pax Exam 4.14.0 in oak-store-composite without upgrading Sling Testing PaxExam.

Changes

  • Align the test host with TinyBundles 4.0.1 and stop inheriting Sling 3.1.0 TestSupport, which references the incompatible TinyBundles 3 API.
  • Preserve required framework setup explicitly, using oak-it-osgi as the SPI Fly/JPMS reference.
  • Use project-managed SLF4J/Logback and avoid duplicate ConfigAdmin provisioning.

Test plan

  • mvn -B -ntp -pl oak-store-composite clean verify -PintegrationTesting passes on actual Java 17, 21 and 25: 55 unit tests and 2 integration tests per JDK.
  • Independent correctness, consistency, compatibility and design reviews found no actionable issues.
  • Spotless is not configured in this repository; RAT and OSGi baseline checks pass.

Links

Co-Authored-By: GitHub Copilot copilot@github.com

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rishabhdaim rishabhdaim self-assigned this Oct 28, 2026
@sonarqubecloud

Copy link
Copy Markdown

@mbaedke mbaedke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just #3267 ?

@rishabhdaim

Copy link
Copy Markdown
Contributor Author

Superseded by #3267, which keeps Sling TestSupport and includes the Java 25 SPI Fly/ASM fix validated on Java 17, 21 and 25. The combined scope is tracked in OAK-12022; OAK-12492 is closed as a duplicate.

@rishabhdaim rishabhdaim closed this Nov 5, 2026
@rishabhdaim
rishabhdaim deleted the OAK-12022 branch November 5, 2026 15:52
@rishabhdaim

Copy link
Copy Markdown
Contributor Author

Why not just #3267?

@mbaedke, your approach is much neater and cleaner, so we're going with #3267; this PR kept Sling 3.1.0 because we originally split the work between OAK-12022 (composite tests on Pax Exam 4.14.0) and OAK-12492 (the Sling Testing PaxExam 4.1.2 upgrade and Java 17/21/25 verification).

We've now consolidated both scopes under OAK-12022, closed OAK-12492 as a duplicate, and closed this PR as superseded, leaving #3267 as the only PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants