Skip to content

Revert "[Fix] Prevent silent subscription data loss on WAL replay gaps (#18741)" - #18786

Merged
jt2594838 merged 2 commits into
masterfrom
revert-silent
Sep 30, 2026
Merged

jt2594838 merged 2 commits into
masterfrom
revert-silent

Merge branch 'master' of https://github.com/apache/iotdb into revert-…

e49d9ad
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Sep 30, 2026 in 3m 18s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 3138 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Distance between variable 'hasExpectedOutputOrdering' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp3K&open=AaDylnxZrspSfsyrgp3K&pullRequest=18786

Check warning on line 1170 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ConfigMTree.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'TableInDeletionException'.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyloTTrspSfsyrgp3d&open=AaDyloTTrspSfsyrgp3d&pullRequest=18786

Check warning on line 391 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof LinearFillNode linearfillnode'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp2z&open=AaDylnxZrspSfsyrgp2z&pullRequest=18786

Check warning on line 183 in iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/AbstractLinearFillOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "cachedBlockIndex".

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyloK0rspSfsyrgp3Z&open=AaDyloK0rspSfsyrgp3Z&pullRequest=18786

Check warning on line 641 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/ConsensusSubscriptionBroker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyln9YrspSfsyrgp3T&open=AaDyln9YrspSfsyrgp3T&pullRequest=18786

Check warning on line 1111 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ConfigMTree.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof FieldColumnSchema fieldColumnSchema'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyloTTrspSfsyrgp3a&open=AaDyloTTrspSfsyrgp3a&pullRequest=18786

Check warning on line 377 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "java.util.List.of()" instead.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp2r&open=AaDylnxZrspSfsyrgp2r&pullRequest=18786

Check warning on line 376 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof PreviousFillNode previousfillnode'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp2q&open=AaDylnxZrspSfsyrgp2q&pullRequest=18786

Check warning on line 253 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/consensus/statemachine/dataregion/DataRegionStateMachine.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyloHyrspSfsyrgp3Y&open=AaDyloHyrspSfsyrgp3Y&pullRequest=18786

Check warning on line 380 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof LinearFillNode linearfillnode'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp2u&open=AaDylnxZrspSfsyrgp2u&pullRequest=18786

Check warning on line 401 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SubscriptionPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do something with the "boolean" value returned by "offer".

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyln_urspSfsyrgp3W&open=AaDyln_urspSfsyrgp3W&pullRequest=18786

Check warning on line 3834 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof GroupNode groupnode'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp3D&open=AaDylnxZrspSfsyrgp3D&pullRequest=18786

Check warning on line 3375 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move the conditional expression inside this operation.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp27&open=AaDylnxZrspSfsyrgp27&pullRequest=18786

Check warning on line 3680 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof GroupNode groupnode'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp2-&open=AaDylnxZrspSfsyrgp2-&pullRequest=18786

Check warning on line 194 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ErrorHandlingUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof SemanticException semanticexception'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyln0lrspSfsyrgp3O&open=AaDyln0lrspSfsyrgp3O&pullRequest=18786

Check warning on line 935 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Distance between variable 'hasExpectedOutputOrdering' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp3J&open=AaDylnxZrspSfsyrgp3J&pullRequest=18786

Check warning on line 3836 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof SortNode sortnode'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp3E&open=AaDylnxZrspSfsyrgp3E&pullRequest=18786

Check warning on line 1167 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ConfigMTree.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'MetadataException'.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyloTTrspSfsyrgp3c&open=AaDyloTTrspSfsyrgp3c&pullRequest=18786

Check warning on line 457 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof ProjectNode projectnode'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp22&open=AaDylnxZrspSfsyrgp22&pullRequest=18786

Check warning on line 3763 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof GroupNode groupnode'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp3C&open=AaDylnxZrspSfsyrgp3C&pullRequest=18786

Check warning on line 383 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "java.util.List.of()" instead.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp2w&open=AaDylnxZrspSfsyrgp2w&pullRequest=18786

Check warning on line 507 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/receiver/SubscriptionReceiverV1.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '235'.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyloGRrspSfsyrgp3X&open=AaDyloGRrspSfsyrgp3X&pullRequest=18786

Check warning on line 716 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/table/DataNodeTableCache.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 168).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDyln2_rspSfsyrgp3Q&open=AaDyln2_rspSfsyrgp3Q&pullRequest=18786

Check warning on line 389 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof NextFillNode nextfillnode'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp2y&open=AaDylnxZrspSfsyrgp2y&pullRequest=18786

Check warning on line 3714 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Distance between variable 'hasExpectedOutputOrdering' declaration and its first usage is 7, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaDylnxZrspSfsyrgp3N&open=AaDylnxZrspSfsyrgp3N&pullRequest=18786