Skip to content

[Subscription] Flush lingering batch before WAL gap retry - #18785

Merged
jt2594838 merged 1 commit into
masterfrom
wal-fix
Sep 30, 2026
Merged

jt2594838 merged 1 commit into
masterfrom
wal-fix

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Summary

  • Flush materialized lingerBatch entries before returning from the pending replay WAL_GAP path.
  • Preserve stale seek handling when flushing fails.
  • Add regression coverage for pending WAL gap retries so already materialized tablets remain pollable.

Tests

  • mvn -o -pl iotdb-core/datanode -Dtest=ConsensusPrefetchingQueueTest#testPendingWalGapFlushesLingerBatchBeforeRetry+testPendingGapReplayHonorsPerRoundWalEntryLimit+testWalReplayRetriesGapWithoutSkippingEntries -DfailIfNoTests=false test
  • mvn -o -pl iotdb-core/datanode -Dtest=ConsensusPrefetchingQueueWalBackpressureTest -DfailIfNoTests=false test

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@jt2594838
jt2594838 merged commit ce14b31 into master Sep 30, 2026
38 of 41 checks passed
@jt2594838
jt2594838 deleted the wal-fix branch September 30, 2026 14:07
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.54%. Comparing base (0c9fb83) to head (1e50448).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...on/broker/consensus/ConsensusPrefetchingQueue.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #18785   +/-   ##
=========================================
  Coverage     45.54%   45.54%           
  Complexity      712      712           
=========================================
  Files          5483     5483           
  Lines        396324   396327    +3     
  Branches      51575    51576    +1     
=========================================
+ Hits         180505   180520   +15     
+ Misses       215819   215807   -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants