Skip to content

Fix TTL expired data ratio in settle compaction #18777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 1 commit into from
Sep 30, 2026
Merged

Fix TTL expired data ratio in settle compaction #18777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ private FileDirtyInfo selectFileBaseOnDirtyData(TsFileResource resource)
// overflow, like 100 - Long.MIN
outdatedTimeDiff = Long.MAX_VALUE;
}
long ttlThreshold = 3 * ttl > ttl ? ttl : Long.MAX_VALUE;
long ttlThreshold = ttl <= Long.MAX_VALUE / 3 ? 3 * ttl : Long.MAX_VALUE;
hasExpiredTooLong =
hasExpiredTooLong
|| outdatedTimeDiff > Math.min(config.getMaxExpiredTime(), ttlThreshold);
Expand All @@ -309,7 +309,8 @@ private FileDirtyInfo selectFileBaseOnDirtyData(TsFileResource resource)
return new FileDirtyInfo(DirtyStatus.FULLY_DIRTY, ttlTables);
}
hasExpiredTooLong = config.getMaxExpiredTime() != Long.MAX_VALUE && hasExpiredTooLong;
if (hasExpiredTooLong || deletedDeviceRatio >= config.getExpiredDataRatio()) {
if (hasExpiredTooLong
|| (deletedDeviceRatio > 0 && deletedDeviceRatio >= config.getExpiredDataRatio())) {
// evaluate dirty data size in the tsfile
return new FileDirtyInfo(
PARTIALLY_DIRTY, (long) (deletedDeviceRatio * resource.getTsFileSize()), ttlTables);
Expand Down
Loading