Skip to content

Fix subscription cache memory configuration - #18761

Merged
jt2594838 merged 3 commits into
apache:masterfrom
Caideyipi:codex/fix-subscription-cache-memory-percentage
Sep 30, 2026
Merged

jt2594838 merged 3 commits into
apache:masterfrom
Caideyipi:codex/fix-subscription-cache-memory-percentage

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Summary

  • cap the initial subscription poll response cache allocation at the configured memory limit while retaining the existing 20% startup target for larger limits
  • validate subscription_cache_memory_usage_percentage as a finite value in [0, 1] and add localized error messages
  • add regression tests for 5%, 10%, 20%, and 50% cache limits and invalid configuration values

Testing

  • targeted CommonDescriptorSubscriptionCacheMemoryUsagePercentageTest (2 tests)
  • targeted SubscriptionPollResponseCacheTest (2 tests)
  • full reactor test-compile with the default English locale
  • full reactor test-compile with with-zh-locale

@jt2594838
jt2594838 merged commit ef9bb52 into apache:master Sep 30, 2026
37 of 39 checks passed
@jt2594838
jt2594838 deleted the codex/fix-subscription-cache-memory-percentage branch September 30, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants