[Fix] Prevent silent subscription data loss on WAL replay gaps - #18741
Merged
jt2594838 merged 5 commits intoSep 30, 2026
Merged
Conversation
jt2594838
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
In the subscription regression, the writer and source-side count both reported 3,999 rows, while the consumer received only 3,942 rows. The server log showed WAL replay advancing from expected searchIndex 57 to actual searchIndex 113, silently skipping the unavailable range [57, 113). The consumer reported no error and the region was still considered caught up.
Tests
The targeted tests were rerun after rebasing onto the latest origin/master: 2 tests, 0 failures, 0 errors.