Conversation
jt2594838
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consensus subscription ownership can assign a consumer only regions that temporarily have no matching events. Even when another region has prefetched data ready, the consumer repeatedly receives empty polls and may hit its idle timeout, reducing the group and leaving a large WAL backlog.
This change keeps stable ownership as the preferred polling path, but when all assigned queues are empty it allows the consumer to borrow one already-prefetched event from an unassigned queue. Fallback queues are ordered by lag, are never waited on, and only one fallback event is returned per topic poll, preserving ownership affinity and response-size behavior.
Unit tests cover both fallback borrowing from a ready queue and retaining strict affinity when an assigned queue has data.
This PR has:
Tests:
mvn spotless:apply -pl iotdb-core/datanodemvn surefire:test -pl iotdb-core/datanode -Dtest=ConsensusSubscriptionBrokerPayloadLimitTest,ConsensusSubscriptionBrokerOwnershipTest -DforkCount=0 -Dsurefire.excludes=Key changed/added classes
ConsensusSubscriptionBrokerConsensusSubscriptionBrokerPayloadLimitTest