Skip to content

Fix sink user pipe visibility and mask credentials in SHOW CREATE PIPE - #18617

Merged
jt2594838 merged 1 commit into
apache:masterfrom
Caideyipi:fix/pipe-user-visibility-show-create
Sep 11, 2026
Merged

Fix sink user pipe visibility and mask credentials in SHOW CREATE PIPE#18617
jt2594838 merged 1 commit into
apache:masterfrom
Caideyipi:fix/pipe-user-visibility-show-create

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

Pipe visibility

  • Fix write-back sink user visibility checks to read connector/sink authentication keys instead of extractor/source keys.
  • Allow associated sink users to query the pipe through SHOW PIPES and SHOW CREATE PIPE.

Credential masking

  • Mask sensitive pipe attribute values in SHOW CREATE PIPE with the shared PipeParameters.ValueHider key rules.
  • Cover source/sink passwords, extractor/connector aliases, and SSL credential keys.

Tests

  • Update ShowCreateTaskTest to verify explicit and alias-prefixed credentials are masked.
  • Extend IoTDBPipePermissionIT to verify sink-user visibility and masked SHOW CREATE PIPE output.
  • Passed targeted ShowCreateTaskTest (9 tests).
  • Passed Spotless for ConfigNode, DataNode, and integration-test.
  • Passed Checkstyle for ConfigNode and DataNode. Integration-test standalone Checkstyle is blocked by its existing unresolved baseDir configuration.
  • The targeted integration-test reactor compiled the changed production modules, but could not reach the IT on this Windows host because existing generated-file RAT/dependency-analysis failures and JVM virtual-memory exhaustion interrupted the build.

This PR has:

  • been self-reviewed.
  • added or updated unit tests.
  • added integration tests.

Key changed/added classes
  • PipeTableResp
  • ShowCreatePipeTask
  • ShowCreateTaskTest
  • IoTDBPipePermissionIT

@jt2594838
jt2594838 merged commit 510c8cd into apache:master Sep 11, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants