Skip to content

[Subscription] Suppress expected commit progress warnings - #18615

Merged
jt2594838 merged 2 commits into
apache:masterfrom
Caideyipi:fix/suppress-unsupported-commit-progress-warn
Sep 11, 2026
Merged

[Subscription] Suppress expected commit progress warnings#18615
jt2594838 merged 2 commits into
apache:masterfrom
Caideyipi:fix/suppress-unsupported-commit-progress-warn

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

DataNodes with subscription_enabled=false intentionally return UNSUPPORTED_OPERATION when
ConfigNode pulls commit progress. The best-effort synchronizer already ignores their progress but
then logs the expected response as a warning.

Suppress that expected status in the best-effort response loop. Other unsuccessful responses still
produce warnings, and required synchronization still rejects UNSUPPORTED_OPERATION.

Validation

  • mvn spotless:apply -pl iotdb-core/confignode
  • mvn -o test -pl iotdb-core/confignode -am -Dtest=CommitProgressSyncProcedureTest -Dsurefire.failIfNoSpecifiedTests=false -Ddevelocity.off=true

The focused test covers expected and unexpected responses, required synchronization, and persistence
of progress from successful DataNodes.


This PR has:

  • been self-reviewed.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.

Key changed/added classes (or packages if there are too many classes) in this PR
  • CommitProgressSyncProcedure

@jt2594838
jt2594838 merged commit 320f0d5 into apache:master Sep 11, 2026
39 checks passed
@jt2594838
jt2594838 deleted the fix/suppress-unsupported-commit-progress-warn branch September 11, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants