Subscription: support encrypted password auth in consumer builder#17480
Open
VGalaxies wants to merge 3 commits intoapache:masterfrom
Open
Subscription: support encrypted password auth in consumer builder#17480VGalaxies wants to merge 3 commits intoapache:masterfrom
VGalaxies wants to merge 3 commits intoapache:masterfrom
Conversation
jt2594838
reviewed
Apr 17, 2026
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.fail; | ||
|
|
||
| @Ignore("TODO: enable after encrypted password subscription IT stabilizes") |
Comment on lines
+128
to
+132
| consume_data(consumer, session_dest); | ||
| check_count( | ||
| 4, | ||
| "select count(s_0) from " + DEVICE + " where time >= 1706659200000", | ||
| "encrypted password consumption"); |
Comment on lines
+151
to
+156
| return new SubscriptionTreePullConsumer.Builder() | ||
| .host(SRC_HOST) | ||
| .port(SRC_PORT) | ||
| .username(USERNAME) | ||
| .password(PASSWORD) | ||
| .encryptedPassword(encryptedPassword) |
Contributor
There was a problem hiding this comment.
It is weird to set both password and encryptedPassword.
May throw an exception setting one when another is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
mvn -T 8 spotless:apply -P with-integration-testsmvn -T 8 clean package -P with-integration-tests -DskipUTs -pl integration-test,distribution -DfailIfNoTests=false -am -UThis PR was primarily authored with Codex using gpt-5.4 xhigh and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.