Skip to content

Remove the release policy option to preserve download files #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dave2wave merged 1 commit into from
Jul 22, 2026
+2 −5
Merged

Remove the release policy option to preserve download files #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ The remaining fields:
| `manual_vote` | boolean | Conduct the vote manually. Mutually exclusive with `vote_mode`. |
| `min_hours` | integer | Minimum hours a vote must remain open. |
| `license_check_mode` | `Both`, `Lightweight` or `RAT` | Which license check(s) to run. |
| `preserve_download_files` | boolean | Keep download files after a release completes. |
| `source_artifact_paths` | list of globs | Paths identifying source artifacts. |
| `binary_artifact_paths` | list of globs | Paths identifying binary artifacts. |
| `source_excludes_lightweight` | list of globs | Paths excluded from the lightweight license check. |
Expand Down
1 change: 0 additions & 1 deletion asfyaml/feature/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
strictyaml.Optional("announce_recipients"): _RECIPIENTS_SCHEMA,
strictyaml.Optional("manual_vote"): strictyaml.Bool(),
strictyaml.Optional("min_hours"): strictyaml.Int(),
strictyaml.Optional("preserve_download_files"): strictyaml.Bool(),
Comment thread
dave2wave marked this conversation as resolved.
strictyaml.Optional("release_checklist"): strictyaml.Str(),
strictyaml.Optional("source_artifact_paths"): strictyaml.Seq(strictyaml.Str()),
strictyaml.Optional("source_excludes_lightweight"): strictyaml.Seq(strictyaml.Str()),
Expand Down
5 changes: 2 additions & 3 deletions tests/project_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@
vote_recipients:
to: private@tooling.apache.org
min_hours: 72
preserve_download_files: true
vote_mode: email
""",
)
Expand Down Expand Up @@ -493,7 +492,7 @@ def test_noop_payload_policy_types(atr_repo: asfyaml.dataobjects.Repository, cap
name: Apache Trusted Releases
policy:
min_hours: 72
preserve_download_files: true
manual_vote: true
license_check_mode: RAT
binary_artifact_paths:
- dist/*.jar
Expand All @@ -511,7 +510,7 @@ def test_noop_payload_policy_types(atr_repo: asfyaml.dataobjects.Repository, cap
out = capsys.readouterr().out
policy = json.loads(out[out.index("{") : out.rindex("}") + 1])["policy"]
assert policy["min_hours"] == 72 # int, not "72"
assert policy["preserve_download_files"] is True # bool, not "true"
assert policy["manual_vote"] is True # bool, not "true"
assert policy["license_check_mode"] == "RAT"
assert policy["binary_artifact_paths"] == ["dist/*.jar"]
assert policy["file_tag_mappings"] == {"sources": ["*.tar.gz"]}
Expand Down
Loading