docs: add a "AI-Generated PR Disclosure" section to AGENTS.md#15758
docs: add a "AI-Generated PR Disclosure" section to AGENTS.md#15758kevinjqliu wants to merge 3 commits intoapache:mainfrom
Conversation
|
Thanks @kevinjqliu for the PR! Should we also talk about AI generated reviews? Maybe add something like "Similarly, if you use AI tools to review PRs, please review the comments for accuracy before posting. Auto-posting AI-generated comments without human review is discouraged." |
|
I generally don't have strong feelings about this in Agent.MD On the con side, everything we put in here is essentially a cost in tokens for all users so I want to make sure it's useful I would recommend we go over the text though and have less "if then" comments and more straight instructions. No need to say "if you are doing this with ai" just say "PR's include this disclosure box after the description" |
|
Why don't we add such a section to the PR template like https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE? |
| @@ -161,6 +161,38 @@ The `api/` module has the strongest stability guarantees — breaking changes ar | |||
| - Commit messages describe the *what* and *why*, not implementation details. | |||
| - Apache License header required on all new files (enforced by spotless pre-commit hook). | |||
There was a problem hiding this comment.
If the code is generated, the copyright doesn't apply.
|
That's good. I think the ash header/copyright should be documented here if the code is AI generated. See the asf guidelines. |
|
For reference, here's the updated guidelines https://www.apache.org/legal/generative-tooling.html Included the Generated-By mention |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
b351727 to
a0b20ed
Compare
|
thanks for the reviews! picking this back up, i've edited the instructions based on reviews. Added a sentence on PR review as well. I'll create a separate PR for the pull request template |
|
added pr template in #16267 |
|
Hi @kevinjqliu, thanks for the AGENTS.md update. A bit off-topic, but it is possible to add a (nearly empty) |
i remember |
Hi @kevinjqliu, from their own docs, https://code.claude.com/docs/en/memory#agents-md, they mention that Claude won't read it automatically:
for example, CLAUDE.md:
I don't use Claude Code directly myself, but it sounds to me like Claude Code users would benefit from a Looks like users have requested the feature, but Anthropic is not going with it yet: anthropics/claude-code#6235. |
Follow up to #15529
Add a section for self-disclosure, esp when PRs themselves are created by an agent.
I have seen several newly opened PR that seem to be fully generated; it would be nice to have some kind of indication on the PR description.