refactor(memory): derive catalog configuration from properties - #3101
Draft
blackmwk wants to merge 4 commits into
Draft
refactor(memory): derive catalog configuration from properties#3101blackmwk wants to merge 4 commits into
blackmwk wants to merge 4 commits into
Conversation
Replace manual catalog property extraction with the shared derive while preserving warehouse validation and forwarding unmodeled properties. Tracks [apache#3095](apache#3095). Generated-by: Codex
blackmwk
commented
Aug 28, 2026
Remove the redundant config wrapper and catch-all property field, expose the typed properties, and retain the catalog name and typed properties on MemoryCatalog. Addresses review feedback on [apache#3101](apache#3101). Generated-by: Codex
blackmwk
commented
Aug 28, 2026
blackmwk
commented
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Propertiesderive.Are these changes tested?
cargo test -p iceberg --lib catalog::memory::catalog::tests::test_catalog_propertiescargo test -p iceberg --lib catalog::memory::catalog::tests::test_create_table_throws_error_if_table_location_and_namespace_location_and_warehouse_location_are_missingcargo clippy -p iceberg --lib --all-features -- -D warningscargo fmt --all -- --checkAI Disclosure
This change was developed with assistance from OpenAI Codex. The contributor reviewed the resulting diff and test output.