feat(scan): make FileScanTask serializable - #3091
Draft
blackmwk wants to merge 5 commits into
Draft
Conversation
Replace the placeholder serde errors with a lossless representation for partition literals and use the existing serde implementations for the remaining scan context fields. Expand round-trip coverage to include a fully populated task and every primitive partition literal. [apache#3089](apache#3089)
blackmwk
commented
Aug 28, 2026
Move the self-describing serde representation into Literal so scan task partitions use the shared values-layer implementation. Cover primitive and nested literal round trips and remove the task-local helper requested in review.
Record the new Serialize and Deserialize implementations for Literal and Struct.
Serialize partition data through the existing RawLiteral implementation using the task schema and partition spec. Remove the direct Literal and Struct serde implementation and keep the public API unchanged.
blackmwk
commented
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
FileScanTaskcontext fields with working serialization.FileScanTaskthat serializes partition data through the existingRawLiteralimplementation.The existing
key_metadatatrust boundary is unchanged: encrypted-file key metadata remains part of a serialized scan task as documented on the field.Are these changes tested?
cargo test -p iceberg --lib(1,585 passed)cargo clippy -p iceberg --lib --tests -- -D warningscargo fmt --all -- --checkgit diff --checkmake check-public-apiAI Disclosure
Codex was used to assist with implementation, regression-test scaffolding, review follow-up, and validation. I reviewed the resulting design and diff, and verified it with the tests and linters listed above. There are no known unresolved assumptions or uncertainties.