perf(table): borrow remaining DataFile metadata in files tables - #1924
Merged
zeroshade merged 1 commit intoAug 27, 2026
Merged
Conversation
zeroshade
approved these changes
Aug 27, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM — the borrowed metadata path preserves ownership and fallback semantics while materially reducing files-table allocations; tests and CI are green.
This review was drafted by an AI-assisted tool and confirmed by an Iceberg Go maintainer. The maintainer approving this PR has read the findings and signed off. If something feels off, please reply on the PR and a maintainer will follow up.
More on how Iceberg Go handles maintainer review:
CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ColumnSizes,KeyMetadata,SplitOffsets, andEqualityFieldIDsfor built-in manifestDataFilevalues.DataFileimplementations.Benchmark
Same benchmark fixture before and after. Apple M1 Pro, darwin/arm64, Go 1.26.3.
-benchtime=3x.files=4096/medium/borrowed: 13.16 ms -> 8.67 ms, 17.3 MB -> 11.3 MB, 45,773 -> 17,102 allocs/op.files=16384/wide/borrowed: 181.0 ms -> 126.2 ms, 247.2 MB -> 153.5 MB, 197,465 -> 82,776 allocs/op.Command:
Checks
go test ./...go test -race ./tablego test -tags=assert -run='^(TestInspectFilesTablesEarlyRelease|TestInspectDataFilesEmitsEmptyBatchWhenAllEntriesAreDeleted|TestInspectDataFilesEmptyTableEarlyRelease|TestInspectPositionDeletesEarlyRelease)$' ./tablego vet ./...golangci-lint run --timeout=10m