Repository navigation
feat(scan): support validated FileScanTask byte ranges - #976
Open
kamcheungting-db wants to merge 2 commits into
Open
kamcheungting-db wants to merge 2 commits into
kamcheungting-db wants to merge 2 commits into
Conversation
kamcheungting-db
marked this pull request as ready for review
October 1, 2026 09:05
Preserve start and length in core and REST JSON, and reject partial reads until the reader can honor ranges.
kamcheungting-db
force-pushed
the
feat/file-scan-task-ranges
branch
from
October 4, 2026 01:59
2014413 to
cce43f7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
FileScanTaskto represent a validated half-open byte range instead of always representing an entire data file.FileScanTask::MakeSplit,start,length, andis_splitFileScanTaskReaderuntil range-aware file reading is implementedBehavior
A full-file range is canonicalized to the existing whole-file task representation. An empty range is valid only for an empty whole file. REST responses may omit both
startandlengthfor compatibility, but providing only one endpoint, null endpoints, or an invalid range returns a parse error.For example, two tasks can cover a 10-byte file without overlap:
{"start": 0, "length": 4} {"start": 4, "length": 6}Scope
This PR models, validates, and transports byte ranges. It does not enable partial file reads yet. Returning
NotSupportedprevents a split task from silently rereading the entire file; range-aware format readers will follow separately.Testing
ctest --test-dir build-clang -R "^(scan_test|data_test|rest_catalog_test)$" --output-on-failureclang-formaton the changed C++ sourcesgit diff --check origin/main...HEAD