Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,15 @@ public boolean keepAlive(
Args.notNull(response, "HTTP response");

if (request != null) {
final boolean contentLenPresent = request.containsHeader(HttpHeaders.CONTENT_LENGTH);
final boolean transferEncodingPresent = request.containsHeader(HttpHeaders.TRANSFER_ENCODING);
// Consider framing of a request message with both Content-Length and Content-Length headers faulty
if (request.containsHeader(HttpHeaders.CONTENT_LENGTH) && request.containsHeader(HttpHeaders.TRANSFER_ENCODING)) {
if (contentLenPresent && transferEncodingPresent) {
return false;
}
// Consider framing of a HTTP/1.0 request message with Transfer-Encoding header faulty
final ProtocolVersion requestVersion = request.getVersion();
if (transferEncodingPresent && requestVersion != null && requestVersion.lessEquals(HttpVersion.HTTP_1_0)) {
return false;
}
final Iterator<String> it = MessageSupport.iterateTokens(request, HttpHeaders.CONNECTION);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -318,5 +318,16 @@ void testResponseHTTP10TransferEncodingPresent() {
Assertions.assertThat(reuseStrategy.keepAlive(null, response, context)).isFalse();
}

@Test
void testRequestHTTP10TransferEncodingPresent() {
final HttpRequest request = new BasicHttpRequest(Method.POST, "/");
request.setVersion(HttpVersion.HTTP_1_0);
request.addHeader("Transfer-Encoding", "chunked");
request.addHeader("Connection", "keep-alive");
final HttpResponse response = new BasicHttpResponse(200, "OK");
response.addHeader("Content-Length", "2");
Assertions.assertThat(reuseStrategy.keepAlive(request, response, context)).isFalse();
}

}

Loading