Repository navigation
Conversation
arturobernalg
left a comment
There was a problem hiding this comment.
The default hostname verifier fallback was intentionally removed in #649.
Would it be better to fix the Conscrypt constructor to use BUILTIN by default, and reject CLIENT without a verifier, rather than restoring the fallback in AbstractClientTlsStrategy?
I'd prefer to preserve the existing separation between verification policy and verifier configuration.
|
@Hsnmohd I agree with @arturobernalg Let's fix it in Conscrypt classes instead. |
|
@Hsnmohd This is wrong and must be fixed. |
|
Agreed, Conscrypt was the right place for this. 9e45136 on master covers every path from the report: the 5-arg |
AbstractClientTlsStrategylost its null-verifier fallback in #649, sonew ConscryptClientTlsStrategy(sslContext)(which hardcodesCLIENT) andsetHostVerificationPolicy(CLIENT)without a verifier skip both endpoint identification and the post-handshake check, and a real exchange withhttps://some-other-hostagainst aCN=localhostcertificate returns 200 through classic, async and a Conscrypt engine, so restoreHttpsSupport.getDefaultHostnameVerifier()forCLIENTandBOTH.